Merge pull request scrapy#4682 from noviluni/remove_python2_reminiscence

remove python 2 reminiscence in cookies
AshitaKaze · Jul 16, 2020 · 9a74a71 · 9a74a71
2 parents b97a39f + 0e0d1ad
commit 9a74a71
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 6 deletions.
diff --git a/scrapy/http/cookies.py b/scrapy/http/cookies.py
@@ -186,9 +186,6 @@ def __init__(self, response):
     def info(self):
         return self
 
-    # python3 cookiejars calls get_all
     def get_all(self, name, default=None):
         return [to_unicode(v, errors='replace')
                 for v in self.response.headers.getlist(name)]
-    # python2 cookiejars calls getheaders
-    getheaders = get_all
diff --git a/tests/test_http_cookies.py b/tests/test_http_cookies.py
@@ -64,9 +64,6 @@ def setUp(self):
     def test_info(self):
         self.assertIs(self.wrapped.info(), self.wrapped)
 
-    def test_getheaders(self):
-        self.assertEqual(self.wrapped.getheaders('content-type'), ['text/html'])
-
     def test_get_all(self):
         # get_all result must be native string
         self.assertEqual(self.wrapped.get_all('content-type'), ['text/html'])