Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting alarm sound, + Fixed a bug #467

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

Vasily-van-Zaam
Copy link

Fixed a bug in playing a melody in the melody selection list

@Vasily-van-Zaam Vasily-van-Zaam changed the title Fixed a bug Selecting alarm sound, + Fixed a bug Jan 8, 2024
@Jon-b-m
Copy link
Member

Jon-b-m commented Jan 9, 2024

I’ve tested this during a few hours so far and seems to be working 👍.

I would very much like you to add separate configurations for low and high. Especially for low glucose it’s important to have a distinctive sound. And regarding high glucose, I think some users might not want a sound, and for those who do preferably a different sound than the low warning sound.

@Vasily-van-Zaam
Copy link
Author

I’ve tested this during a few hours so far and seems to be working 👍.

I would very much like you to add separate configurations for low and high. Especially for low glucose it’s important to have a distinctive sound. And regarding high glucose, I think some users might not want a sound, and for those who do preferably a different sound than the low warning sound.

Fine. I'll try to figure out how to implement this.

@Jon-b-m
Copy link
Member

Jon-b-m commented Jan 9, 2024

Great, Thanks!

@Vasily-van-Zaam
Copy link
Author

i think we need to create multiple event types.

  1. low glucose level
  2. high glucose levels
  3. rapid drop in glucose levels
  4. Rapid increase in glucose levels.
  5. Closed loop error.
    Because if we only have "low" or "high" it will add more questions about how it will work.

@Jon-b-m
Copy link
Member

Jon-b-m commented Jan 9, 2024

I guess you're right. It has been requested before. If you want to do it all in one go (preferably) or dividing it up into smaller parts or to delegate some of it to me or to someone else that would also be OK.

@Vasily-van-Zaam
Copy link
Author

Fine. I'll try to find time for this. I'll slowly start studying the code to understand how to implement this.

@Jon-b-m
Copy link
Member

Jon-b-m commented May 10, 2024

How is the work going for this one? Is it still in progress?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

2 participants