Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add index to EntryState #933

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Add index to EntryState #933

merged 3 commits into from
Sep 30, 2024

Conversation

herring-swe
Copy link
Contributor

Change to enable checking item index via MenuEntryOption.transform, so custom code can fetch data instead of relying on label string.

Note the index lookup via parent in MenuEntry.

@herring-swe herring-swe mentioned this pull request Sep 29, 2024
Closed
ArthurSonzogni
ArthurSonzogni approved these changes Sep 30, 2024
View reviewed changes
Copy link
Owner

@ArthurSonzogni ArthurSonzogni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! THanks!

@ArthurSonzogni ArthurSonzogni merged commit 1d40687 into ArthurSonzogni:main Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArthurSonzogni ArthurSonzogni ArthurSonzogni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@herring-swe @ArthurSonzogni