Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ip input component #737

Closed
wants to merge 3 commits into from
Closed

Conversation

mingsheng13
Copy link
Contributor

@mingsheng13 mingsheng13 commented Aug 28, 2023

I wrote a component for inputting IPV4 address. One bug that I wasn't able to fix is when using cursor to remove the dots it breaks the logic. I think the only way to fix this is to be able to get the cursor_position() outside the Input component.

@ArthurSonzogni
Copy link
Owner

Thanks @mingsheng13 !

As as said in: #672
I believe an IpInput component to be too specific for FTXUI. If you made a repository, I could contribute to make the CMake config usable for others and reference it from:
https://github.com/ArthurSonzogni/FTXUI#libraries-for-ftxui
?

I really would like folks to add their own set of components, maybe this could be the first one?

@mingsheng13
Copy link
Contributor Author

As as said in: #672 I believe an IpInput component to be too specific for FTXUI. If you made a repository, I could contribute to make the CMake config usable for others and reference it from: https://github.com/ArthurSonzogni/FTXUI#libraries-for-ftxui ?

Thank you for the reply. That's actually what I wanted to do! I'll make it in my repo.

@mingsheng13
Copy link
Contributor Author

I've moved it to here. https://github.com/mingsheng13/ip-input-ftxui . Please tell me if I'm doing anything wrong. Thanks :)

@ArthurSonzogni
Copy link
Owner

Awesome!

I forked your repository and improved it. I will work on it for a few days and submit PR against your repository when I am done.

@mingsheng13
Copy link
Contributor Author

Thanks! I had a look at the fork and was impressed by the code quality. Wish I could be as good as you 😭

@ArthurSonzogni
Copy link
Owner

Thanks!

I added ftxui-ip-input in the FTXUI README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants