Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some grammar online demos not working #19

Open
mingodad opened this issue Mar 23, 2021 · 2 comments
Open

Some grammar online demos not working #19

mingodad opened this issue Mar 23, 2021 · 2 comments
Assignees
@ArthurSonzogni

Comments

@mingodad
Copy link

When trying https://arthursonzogni.com/Diagon/#Grammar and selecting ISO-EBNF-EBNF we get this error:

2:14: Syntax error: expected production rule separator

And when selecting WSN-WSN we get this error:

2:14: Syntax error
@mingodad
Copy link
Author

My bad it seems that we need to select input and output according, maybe could be a good idea to auto select then for the demos in a way that at least do not give an error.

@ArthurSonzogni
Copy link
Owner

Adding the "auto" mode for input seems like a nice addition.

For this translator, I am reusing the KGT project. Unfortunately, this wasn't really supposed to be called as a library and this project is using "exit(...)" in many places, which prevents Diagon from continuing on errors.

I remember I started working on this here:
katef/kgt#38
but I am not sure I finished. I would have to to implement your feature.

+CC: @katef FYI.

@ArthurSonzogni ArthurSonzogni self-assigned this Mar 25, 2021
ArthurSonzogni added a commit to ArthurSonzogni/kgt that referenced this issue Mar 27, 2021
@ArthurSonzogni
Stop using exit in parser.
d1ca569 
Using exit(EXIT_FAILURE) in the middle of a function makes kgt hard to
be embedded as a library, because it interrupts the caller.

The previous patch removed usage of exit for every generators:
katef#40

This one removes usage of exit for every parser. The parsing_error
struct is introduced to list all the errors.

Issue:
- katef#38
- ArthurSonzogni/Diagon#19
ArthurSonzogni added a commit to ArthurSonzogni/kgt that referenced this issue Mar 27, 2021
@ArthurSonzogni
Stop using exit in parser.
1780a73 
Using exit(EXIT_FAILURE) in the middle of a function makes kgt hard to
be embedded as a library, because it interrupts the caller.

The previous patch removed usage of exit for every generators:
katef#40

This one removes usage of exit for every parser. The parsing_error
struct is introduced to list all the errors.

Issue:
- katef#38
- ArthurSonzogni/Diagon#19
ArthurSonzogni added a commit to ArthurSonzogni/kgt that referenced this issue Mar 27, 2021
@ArthurSonzogni
Stop using exit in parser.
ad55241 
Using exit(EXIT_FAILURE) in the middle of a function makes kgt hard to
be embedded as a library, because it interrupts the caller.

The previous patch removed usage of exit for every generators:
katef#40

This one removes usage of exit for every parser. The parsing_error
struct is introduced to list all the errors.

Issue:
- katef#38
- ArthurSonzogni/Diagon#19
@ArthurSonzogni ArthurSonzogni mentioned this issue Mar 27, 2021
Merged
ArthurSonzogni added a commit to ArthurSonzogni/kgt that referenced this issue Apr 5, 2021
@ArthurSonzogni
Stop using exit in parser.
b1b825a 
Using exit(EXIT_FAILURE) in the middle of a function makes kgt hard to
be embedded as a library, because it interrupts the caller.

The previous patch removed usage of exit for every generators:
katef#40

This one removes usage of exit for every parser. The parsing_error
struct is introduced to list all the errors.

Issue:
- katef#38
- ArthurSonzogni/Diagon#19
katef pushed a commit to katef/kgt that referenced this issue Apr 6, 2021
@ArthurSonzogni @katef
Stop using exit in parser.
a7cbc52 
Using exit(EXIT_FAILURE) in the middle of a function makes kgt hard to
be embedded as a library, because it interrupts the caller.

The previous patch removed usage of exit for every generators:
#40

This one removes usage of exit for every parser. The parsing_error
struct is introduced to list all the errors.

Issue:
- #38
- ArthurSonzogni/Diagon#19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArthurSonzogni ArthurSonzogni

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mingodad @ArthurSonzogni