Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RBMK Power Buff + Bug Fixes and Heat Sink #564

Merged
merged 39 commits into from
Dec 23, 2024

Conversation

RimiNosha
Copy link
Contributor

@RimiNosha RimiNosha commented Mar 28, 2024

About The Pull Request

The stock RBMK setup makes like a third of the power as an SM shard. Let's buff it.

Heat sail sprite is a bastardized sprite from one of NSV's guns.

Fixes the power number:

  • Jumping to a stupid high value when the reactor stops generating power.
  • Staying at the last power generated when the reactor stops generating power.
  • Not being on the modcomp program.
  • Being a bar instead of a text entry.

Known issues:

  • Heat sink heat flickers every other second for some reason.
  • Heat sink can "connect" on all sides, but only the bottom left actually connects.
  • Probably can be constructed into walls, but honestly I'm beyond caring.

How Does This Help Gameplay?

Engineering can actually power the ship without having to meltdown the reactor.

Proof of Testing

Screenshots/Videos

Changelog

🆑
fix: Fixed many RBMK UI issues.
add: Heat sink. Cools down things to ambient, so great for regulating high temps, but useless for anything that needs below ambient temps.
qol: The reactor is also actually usable now. Nice.
/:cl:

@RimiNosha RimiNosha marked this pull request as draft March 28, 2024 16:51
@github-actions github-actions bot added Mapping Something something someone placed three reinforced window spawners in one place. Sprites I like pretty things. UI Also known as "I like lagspikes, so I added TGUI to your TGUI". Merge Conflict Uh oh, a maint merged a PR that edits the same stuff as yours! labels Mar 30, 2024
Copy link
Contributor

github-actions bot commented Apr 7, 2024

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the Stale "Anyone home?" label Apr 7, 2024
@github-actions github-actions bot closed this Apr 14, 2024
@RimiNosha RimiNosha reopened this Apr 19, 2024
@RimiNosha RimiNosha removed the Stale "Anyone home?" label Apr 19, 2024
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the Stale "Anyone home?" label Apr 27, 2024
@github-actions github-actions bot closed this May 5, 2024
@RimiNosha RimiNosha removed the Stale "Anyone home?" label May 5, 2024
@RimiNosha RimiNosha reopened this May 5, 2024
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the Stale "Anyone home?" label May 13, 2024
@github-actions github-actions bot closed this May 21, 2024
@RimiNosha RimiNosha removed the Stale "Anyone home?" label May 21, 2024
@RimiNosha RimiNosha reopened this May 21, 2024
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the Stale "Anyone home?" label Jul 26, 2024
@github-actions github-actions bot closed this Aug 2, 2024
@RimiNosha RimiNosha removed the Stale "Anyone home?" label Aug 3, 2024
@RimiNosha RimiNosha reopened this Aug 3, 2024
@github-actions github-actions bot added the Merge Conflict Uh oh, a maint merged a PR that edits the same stuff as yours! label Aug 25, 2024
# Conflicts:
#	_maps/map_files/ALV Belryth/ALV Belryth.dmm
@RimiNosha RimiNosha removed the Merge Conflict Uh oh, a maint merged a PR that edits the same stuff as yours! label Aug 25, 2024
@github-actions github-actions bot added the Merge Conflict Uh oh, a maint merged a PR that edits the same stuff as yours! label Oct 5, 2024
@RimiNosha RimiNosha removed the Merge Conflict Uh oh, a maint merged a PR that edits the same stuff as yours! label Oct 7, 2024
@github-actions github-actions bot added Merge Conflict Uh oh, a maint merged a PR that edits the same stuff as yours! and removed Merge Conflict Uh oh, a maint merged a PR that edits the same stuff as yours! labels Oct 7, 2024
@RimiNosha RimiNosha changed the title [WIP] RBMK Power Buff, Bug Fixes and Space Radiator RBMK Power Buff + Bug Fixes and Heat Sink Oct 30, 2024
@RimiNosha
Copy link
Contributor Author

Fuck it, I'm at my tether's end and I want to work on something I actually enjoy that isn't this hellcode that's called atmos pipenets.

@RimiNosha RimiNosha marked this pull request as ready for review October 30, 2024 16:49
@github-actions github-actions bot added Feature How I broke the server in one easy step! Fix Cleans up someone else's code from 5 years ago. Quality of Life Also known as "I deleted a ton of other things and made one particular thing the only way". labels Oct 30, 2024
@RimiNosha RimiNosha merged commit 554ec77 into Artea-Station:master Dec 23, 2024
17 checks passed
Artea-Station-Bot added a commit that referenced this pull request Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature How I broke the server in one easy step! Fix Cleans up someone else's code from 5 years ago. Mapping Something something someone placed three reinforced window spawners in one place. Quality of Life Also known as "I deleted a ton of other things and made one particular thing the only way". Sprites I like pretty things. UI Also known as "I like lagspikes, so I added TGUI to your TGUI".
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant