Fix non main game world entities being tracked in persistence #30

Arkensor · Feb 12, 2024 · ffd000c · ffd000c
1 parent 956b88e
commit ffd000c
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 6 deletions.
diff --git a/src/Scripts/Game/EPF_EntitySaveData.c b/src/Scripts/Game/EPF_EntitySaveData.c
@@ -70,9 +70,13 @@ class EPF_EntitySaveData : EPF_MetaDataDbEntity
 		if (EPF_BitFlags.CheckFlags(flags, EPF_EPersistenceFlags.ROOT) &&
 			attributes.m_bSaveRemainingLifetime)
 		{
-			auto garbage = ChimeraWorld.CastFrom(entity.GetWorld()).GetGarbageManager();
-			if (garbage)
-				m_fRemainingLifetime = garbage.GetRemainingLifetime(entity);
+			auto garbageWorld = ChimeraWorld.CastFrom(entity.GetWorld());
+			if (garbageWorld)
+			{
+				auto garbage = garbageWorld.GetGarbageManager();
+				if (garbage)
+					m_fRemainingLifetime = garbage.GetRemainingLifetime(entity);
+			}
 
 			if (m_fRemainingLifetime == -1)
 			{
@@ -146,9 +150,13 @@ class EPF_EntitySaveData : EPF_MetaDataDbEntity
 		// Lifetime
 		if (attributes.m_bSaveRemainingLifetime)
 		{
-			auto garbage = ChimeraWorld.CastFrom(entity.GetWorld()).GetGarbageManager();
-			if (garbage && m_fRemainingLifetime > 0)
-				garbage.Insert(entity, m_fRemainingLifetime);
+			auto garbageWorld = ChimeraWorld.CastFrom(entity.GetWorld());
+			if (garbageWorld)
+			{
+				auto garbage = garbageWorld.GetGarbageManager();
+				if (garbage && m_fRemainingLifetime > 0)
+					garbage.Insert(entity, m_fRemainingLifetime);
+			}
 		}
 
 		// Components

diff --git a/src/Scripts/Game/EPF_PersistenceComponent.c b/src/Scripts/Game/EPF_PersistenceComponent.c
@@ -303,6 +303,10 @@
 		// Persistence logic only runs on the server
 		if (!EPF_PersistenceManager.IsPersistenceMaster())
 			return;
+
+		// Avoid tracking anything in preload/preview world
+		if (!ChimeraWorld.CastFrom(owner.GetWorld()) || (GetGame().GetWorld() != owner.GetWorld()))
+			return;
 
 		// Init and validate settings on shared class-class instance once
 		EPF_PersistenceComponentClass settings = EPF_PersistenceComponentClass.Cast(GetComponentData(owner));