Add GPIO current limit warning(s) #6180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hwurzburg
requested changes
Aug 14, 2024
There was a problem hiding this comment.
we dont have a gripper that uses a gpio, my mistake....but we do use the output pins many other places like ice ignition/start,etc. but I dont think we need to worry about those since they are logic outputs to those devices...perhaps the buzzer page after line 32?
| @@ -4,6 +4,9 @@ | |||
| Buttons | |||
| ======= | |||
|
|
|||
| .. warning:: | |||
There was a problem hiding this comment.
buttons are configured as inputs,not outputs so dont need this warning
There was a problem hiding this comment.
Fixed along with adding same for buzzer. Agree on the other various functions - I took a look at a solid sample of those and came to the same conclusion.
yuri-rage
force-pushed
the
gpio-warning
branch
from
2d8d61f to
a53ecc6
Compare
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Included a GPIO current limit warning and referenced it on associated common articles.