Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it work again in Python 3.10 #215

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

iacore
Copy link

@iacore iacore commented Mar 20, 2022

No description provided.

@TheTechRobo
Copy link
Contributor

This PR's Pipfile makes the minimum version Python 3.10; this will break it for many users.

Also, the fixes for ludios_wpull should be merged into ludios_wpull officially before this is.

@iacore
Copy link
Author

iacore commented Mar 21, 2022

Most users probably don't use Pipfile for installing the package. Also, I don't know which minimum version will work.

Also, what's the deal with ludios_wpull and https://github.com/ArchiveTeam/wpull?

@TheTechRobo
Copy link
Contributor

TheTechRobo commented Mar 21, 2022

ludios_wpull is @ivan 's fork of wpull when it appeared that wpull wasn't maintained (still isn't); he made a bunch of breaking changes.

ludios works with more versions of python (although still not the latest)

@ivan
Copy link
Contributor

ivan commented May 6, 2022

I believe this PR does not make grab-site work with Python 3.10 because we still have incompatibilities preventing an upgrade to Python 3.9 (ArchiveTeam/ludios_wpull#20)

@ivan ivan closed this May 6, 2022
@ivan
Copy link
Contributor

ivan commented May 6, 2022

oh, I see you made changes to wpull in your fork. I guess I would need Python 3.10 support to be upstream in ArchiveTeam/ludios_wpull (or ArchiveTeam/wpull if the useful ludios_wpull changes are incorporated.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants