Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: more idiomatic java 17, remove "i" prefix #1916

Merged
merged 10 commits into from
Jan 24, 2025
Merged

Conversation

robfrank
Copy link
Collaborator

@robfrank robfrank commented Jan 15, 2025

What does this PR do?

Refactor to use more java 17 idioms
Replace most of i prefixed parameters

yes, it's huge, but it contains just cosmetic changes

Motivation

Evolve the code to be ready when we can migrate to java 21

Checklist

  • I have run the build using mvn clean package command
  • My unit tests cover both failure and success scenarios

engine/pom.xml Fixed Show fixed Hide fixed
Copy link

codacy-production bot commented Jan 15, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for b450b041 51.62%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (b450b04) Report Missing Report Missing Report Missing
Head commit (cbc739b) 68184 43978 64.50%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1916) 2879 1486 51.62%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@robfrank robfrank requested a review from lvca January 15, 2025 13:38
@robfrank robfrank marked this pull request as ready for review January 24, 2025 14:12
@robfrank robfrank changed the title Chore: java 17 and general cleanup Chore: more idiomatic java 17, remove "i" prefix Jan 24, 2025
@robfrank robfrank merged commit 4bd7adc into main Jan 24, 2025
7 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants