-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add explanations for io-library assignment #74
Open
iddm
wants to merge
12
commits into
Apress:master
Choose a base branch
from
iddm:patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds not-fully written explanations for the io-library assignment. This would be good for people who want to understand the code.
@sayon I am not a good writer, nor I am best at assembly language. But I want to help people, and I think adding such explanations for the assignment is very useful for people like me, who still has some troubles understanding the assembly language. |
Adds explanation for the `print_uint` function.
Adds some corrections to the text.
Adds explanations for the `print_int` and `read_char` functions.
Add explanation for the `parse_uint` and `parse_int` functions
Corrects the identation in the `parse_uint` explanation
Adds `string_equals` explanation
Adds explanation for the `string_copy` function.
Adds explanation for the `read_word` function.
Adds the `read_word` function call graph for better understanding.
Updates the read_word function's call graph image to better one
The text has grammar and syntax errors and typos, but the idea is finished and all functions are covered now. Ready for review. |
Adds some text corrections (grammar, syntax, etc) into the explanation of io-library assignment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds not-fully written explanations for the io-library assignment.
This would be good for people who want to understand the code.