fix: move task such as it is destory after complete, to release potential shared ptr holding #15633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
superMan-1012
force-pushed
the
feature/optimize_task_dequeue
branch
from
586acd0 to
09a4798
Compare
superMan-1012
force-pushed
the
feature/optimize_task_dequeue
branch
from
09a4798 to
33ed29b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the BoundedQueue class to intelligently handle element assignments by distinguishing between move-assignable and non-move-assignable types. By introducing templated assign functions and updating the Dequeue method accordingly, the queue now benefits from optimized performance without sacrificing compatibility