Fix Swagger warnings for properties #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -79,7 +79,7 @@ def for_default | |||
| end | |||
|
|
|||
| def required? | |||
| required_from_path? || (!@in_schema && @param_description.required) | |||
| required_from_path? || @param_description.required | |||
There was a problem hiding this comment.
@PanosCodes can you confirm we can remove this check here?
|
Can you run the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix the #888 issue. I'm not sure how exactly the
in_schemais used and whether we can just ignore it inApipie::Generator::Swagger::ParamDescription::Builder. But since thein_schemais almost alwaystrue, I couldn't find a way how to combine it with theparam_descriptionin other way.