-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate to null safety #13
base: master
Are you sure you want to change the base?
chore: migrate to null safety #13
Conversation
@AntoineMarcel Are you willing to accept this PR? |
Do you have any pending review issues? Could you merge? |
I would appreciate if you could merge this. In case you are looking for maintainers for the project, please communicate this. We'd otherwise publish a fork on pub.dev as we do not want to permanently rely on git imports. |
@TheOneWithTheBraid could you also update your branch to have the example be null safe? And also, did you publish a fork on pub? |
@CaptainDario I correspondingly updated the example and moreover adjusted the gitignore. Does it look sound now? No, it wasn't me who published the fork. I always prefer to contribute to existing projects rather than publishing short-time forks. |
5aa8786
to
2906e65
Compare
@CaptainDario Does the PR look sound to you? I would love to see this merged & published soon. |
@TheOneWithTheBraid looks good to me! However, it seems like you got the wrong idea. I am not a maintainer of this package. I just wanted to use this package and stumbled upon your branch. I would also update the dependencies: tuple: 2.0.0
visibility_detector: 0.3.3 |
Signed-off-by: TheOneWithTheBraid <[email protected]>
2906e65
to
a3d4020
Compare
Are you still planning to merge this some day, @AntoineMarcel? Null-safety is nowadays really required for proper Dart code. |
Migrated to null safety