Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate to null safety #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TheOneWithTheBraid
Copy link

Migrated to null safety

@TheOneWithTheBraid
Copy link
Author

@AntoineMarcel Are you willing to accept this PR?

@TheOneWithTheBraid
Copy link
Author

Do you have any pending review issues? Could you merge?

@TheOneWithTheBraid
Copy link
Author

I would appreciate if you could merge this. In case you are looking for maintainers for the project, please communicate this.

We'd otherwise publish a fork on pub.dev as we do not want to permanently rely on git imports.

@CaptainDario
Copy link

CaptainDario commented May 27, 2022

@TheOneWithTheBraid could you also update your branch to have the example be null safe?

And also, did you publish a fork on pub?

@TheOneWithTheBraid
Copy link
Author

@CaptainDario I correspondingly updated the example and moreover adjusted the gitignore.

Does it look sound now?

No, it wasn't me who published the fork. I always prefer to contribute to existing projects rather than publishing short-time forks.

@TheOneWithTheBraid
Copy link
Author

@CaptainDario Does the PR look sound to you? I would love to see this merged & published soon.

@CaptainDario
Copy link

@TheOneWithTheBraid looks good to me! However, it seems like you got the wrong idea. I am not a maintainer of this package. I just wanted to use this package and stumbled upon your branch.
That is why I asked if you released a separate package. It looks like this package will never get maintenance and therefore I guess it will make sense to publish a fork as the keyboard shortcut mechanics in flutter are kind of tricky to use (at least in my opinion)...

I would also update the dependencies:

tuple: 2.0.0
visibility_detector: 0.3.3

Signed-off-by: TheOneWithTheBraid <[email protected]>
@TheOneWithTheBraid
Copy link
Author

Are you still planning to merge this some day, @AntoineMarcel? Null-safety is nowadays really required for proper Dart code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants