fix(html): duplicate id #296
Conversation
|
What I'm wondering here, is why we have the language dropdown twice in the first place. I believe one is for mobile view, the other 'desktop'. Wouldn't it be better to 'merge' them (code-wise), if possible? |
|
Is this maybe also something we could change with the new website design? |
Rotzbua
force-pushed
the
fix_validator_id
branch
from
e7ad7fb
to
575e6e9
Compare
|
@keunes Yes there are two language dropdowns. One for mobile and one for desktop. Since it is a very simple fix, I see no reason to wait until a future solution (refactor, new design) implement it. |
Rotzbua
force-pushed
the
fix_validator_id
branch
from
575e6e9
to
230f4c1
Compare
Fair enough. @ByteHamster I agreed initially that this could be addressed with the website update. But we're probably going to get raw HTML+CSS and would have to translate it into Jekyll+SASS ourselves (if I understood correctly). Meaning we might just take/implement the CSS changes and update the Jekyll includes/templates (rather than reconverting from scratch). In that scenario we'd probably have to refactor the mobile menu separately. @Rotzbua Would it be feasible for you to refactor the language menu now? If yes, I think that'd be great. If not, could I ask you you to resolve the conflict? |
Error: Duplicate ID navbarDropdown. Source: Nu Html Checker
Rotzbua
force-pushed
the
fix_validator_id
branch
from
230f4c1
to
419ffd1
Compare
|
Thanks a lot for your contributions. Sorry for not merging sooner! |
Error: Duplicate ID navbarDropdown.
Source: Nu Html Checker