Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor subscribe JS #257

Merged
merged 1 commit into from
Aug 26, 2023
Merged

Refactor subscribe JS #257

merged 1 commit into from
Aug 26, 2023

Conversation

Rotzbua
Copy link
Contributor

@Rotzbua Rotzbua commented Jul 26, 2023

Change

Remove jQuery dependency. Preparation for #203.

@keunes keunes requested a review from ByteHamster August 4, 2023 16:18
@keunes
Copy link
Member

keunes commented Aug 16, 2023

Hi @Rotzbua,
Just FYI: I think this needs a proper code review and I can't do that. We'll have to wait until ByteHamster is available again, starting from next week.

ByteHamster
ByteHamster reviewed Aug 18, 2023
View reviewed changes
Copy link
Member

@ByteHamster ByteHamster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I would make the whitespace consistent, as suggested in my comments.

deeplink/subscribe/index.html Outdated Show resolved Hide resolved
deeplink/subscribe/index.html Outdated Show resolved Hide resolved
@Rotzbua @ByteHamster
Refactor subscribe JS
1f9c5f7 
Remove jQuery dependency.

Co-Authored-By: ByteHamster <[email protected]>
@keunes keunes merged commit ea46ea2 into AntennaPod:master Aug 26, 2023
3 checks passed
@Rotzbua Rotzbua deleted the refactor_js_subscribe branch August 26, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ByteHamster ByteHamster ByteHamster left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rotzbua @keunes @ByteHamster