Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add status codes when missing from exception handlers #460

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pydanny
Copy link
Collaborator

@pydanny pydanny commented Sep 24, 2024


name: Pull Request
about: Propose changes to the codebase
title: '[PR] Add status codes when missing from exception handlers'
labels: 'enhancement'
assignees: ''


Proposed Changes

When exception_handlers don't specify a status_code in the returned Response, this will add it for them from the specified exception_handlers.

Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • [x New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist
Go over all the following points, and put an x in all the boxes that apply:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I am aware that this is an nbdev project, and I have edited, cleaned, and synced the source notebooks instead of editing .py or .md files directly.

Additional Information

Inspired by this code, which I added after it was pointed out that my 404 pages didn't return 404 status codes: https://github.com/pydanny/daniel-blog-fasthtml/blob/main/main.py#L24-L38

Copy link

gitnotebooks bot commented Sep 24, 2024

Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/AnswerDotAI/fasthtml/pull/460

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant