Add status codes when missing from exception handlers #460
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Pull Request
about: Propose changes to the codebase
title: '[PR] Add status codes when missing from exception handlers'
labels: 'enhancement'
assignees: ''
Proposed Changes
When
exception_handlers
don't specify astatus_code
in the returnedResponse
, this will add it for them from the specifiedexception_handlers
.Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Checklist
Go over all the following points, and put an
x
in all the boxes that apply:Additional Information
Inspired by this code, which I added after it was pointed out that my 404 pages didn't return 404 status codes: https://github.com/pydanny/daniel-blog-fasthtml/blob/main/main.py#L24-L38