fix: agToken update #205
fix: agToken update #205
Conversation
|
I only see format update on this PR |
sogipec
force-pushed
the
agToken-update
branch
from
82c0a45 to
1462799
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| /// @inheritdoc IAgToken | ||
| function setTreasury(address _treasury) external onlyTreasury { |
Check notice
Code scanning / Slither
Missing zero address validation Low
| /// @notice Reference to the treasury contract which can grant minting rights | ||
| address public treasury; | ||
| /// @notice Boolean used to check whether the contract had been reinitialized after an upgrade | ||
| bool public treasuryInitialized; |
Check warning
Code scanning / Slither
State variables that could be declared constant Warning
| // ================================= REFERENCES ================================ | ||
|
|
||
| /// @notice Reference to the `StableMaster` contract associated to agEUR | ||
| address public stableMaster; |
Check warning
Code scanning / Slither
State variables that could be declared constant Warning
| isMinter[minter] = false; | ||
| emit MinterToggled(minter); | ||
| } | ||
|
|
||
| /// @inheritdoc IAgToken | ||
| function setTreasury(address _treasury) external onlyTreasury { | ||
| function setTreasury(address _treasury) external virtual onlyTreasury { |
Check notice
Code scanning / Slither
Missing zero address validation Low
|
|
||
| export const immutableCreate2Factory = '0x0000000000FFe8B47B3e2130213B802212439497'; | ||
|
|
||
| export const OFTs: OFTsStructure = { |
There was a problem hiding this comment.
We can do a call to our sdk for that
There was a problem hiding this comment.
We can, only reason why I'm fine not doing it now is because when you deploy it's often a pain to have to wait for the SDK update to get all the addresses here
There was a problem hiding this comment.
I am not sure I understand your point?
sogipec
force-pushed
the
agToken-update
branch
from
d588a4e to
2f59eec
Compare
|
|
||
| export const immutableCreate2Factory = '0x0000000000FFe8B47B3e2130213B802212439497'; | ||
|
|
||
| export const OFTs: OFTsStructure = { |
There was a problem hiding this comment.
I am not sure I understand your point?
| function _getQuoteAmount() internal view virtual returns (uint256) { | ||
| return 10 ** 18; | ||
| } |
Check warning
Code scanning / Slither
Dead-code Warning
| import { parseAmount } from '../../utils/bignumber'; | ||
|
|
||
| const flashLoanParams = { | ||
| // 3m at the moment, should not be too big with respect to the total agEUR in circulation |
There was a problem hiding this comment.
Maybe lower with stUSD as we don't know the growth yet
|
|
||
| export const interestRate5 = BigNumber.from('1547125982881425408'); | ||
|
|
||
| export const vaultManagers = { |
There was a problem hiding this comment.
Why is it in this repo and not the sdk one?
There was a problem hiding this comment.
Because we removed the parameters from the sdk
sogipec
force-pushed
the
agToken-update
branch
from
894f7a7 to
2f9e9c9
Compare
No description provided.