refactor(compiler): Handle trailing spaces in ICU placeholders (angul…

…ar#52698)

In some cases ICU expression placeholders may have trailing spaces that
need to be trimmed when matching the placeholder to its corresponding
text binding.

PR Close angular#52698

packages/compiler-cli/test/compliance/test_cases/r3_view_compiler_i18n/icu_logic/TEST_CASES.json

@@ -222,8 +222,7 @@
             "verifyUniqueConsts"
           ]
         }
-      ],
-      "skipForTemplatePipeline": true
+      ]
     },
     {
       "description": "should produce proper messages when `select` or `plural` keywords have spaces after them",
@@ -237,8 +236,7 @@
             "verifyUniqueConsts"
           ]
         }
-      ],
-      "skipForTemplatePipeline": true
+      ]
     }
   ]
 }

packages/compiler/src/template/pipeline/src/ingest.ts

@@ -492,7 +492,7 @@ function ingestIcu(unit: ViewCompilationUnit, icu: t.Icu) {
     const xref = unit.job.allocateXrefId();
     const icuNode = icu.i18n.nodes[0];
     unit.create.push(ir.createIcuStartOp(xref, icu.i18n, icuFromI18nMessage(icu.i18n).name, null!));
-    const {expressionPlaceholder} = icuNode;
+    const expressionPlaceholder = icuNode.expressionPlaceholder?.trimEnd();
     if (expressionPlaceholder === undefined || icu.vars[expressionPlaceholder] === undefined) {
       throw Error('ICU should have a text binding');
     }

packages/compiler/src/template/pipeline/src/phases/i18n_const_collection.ts

@@ -204,12 +204,14 @@ function i18nGenerateClosureVar(
  * Asserts that all of the message's placeholders have values.
  */
 function assertAllParamsResolved(op: ir.I18nMessageOp): asserts op is ir.I18nMessageOp {
-  for (const placeholder in op.message.placeholders) {
+  for (let placeholder in op.message.placeholders) {
+    placeholder = placeholder.trimEnd();
     if (!op.params.has(placeholder) && !op.postprocessingParams.has(placeholder)) {
       throw Error(`Failed to resolve i18n placeholder: ${placeholder}`);
     }
   }
-  for (const placeholder in op.message.placeholderToMessage) {
+  for (let placeholder in op.message.placeholderToMessage) {
+    placeholder = placeholder.trimEnd();
     if (!op.params.has(placeholder) && !op.postprocessingParams.has(placeholder)) {
       throw Error(`Failed to resolve i18n message placeholder: ${placeholder}`);
     }