refactor(compiler-cli): rephrase an error message related to @defer…

… and local compilation This commit updates the error message to cover cases when imported symbols have eager references inside of a file.
AndrewKushnir · Jan 18, 2024 · 421630f · 421630f
1 parent e227275
commit 421630f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 10 deletions.
diff --git a/packages/compiler-cli/src/ngtsc/annotations/component/src/handler.ts b/packages/compiler-cli/src/ngtsc/annotations/component/src/handler.ts
@@ -685,12 +685,12 @@ export class ComponentDecoratorHandler implements
       for (const importDecl of nonRemovableImports) {
         const diagnostic = makeDiagnostic(
             ErrorCode.DEFERRED_DEPENDENCY_IMPORTED_EAGERLY, importDecl,
-            `This import contains symbols used in the \`@Component.deferredImports\` array ` +
-                `of the \`${node.name.getText()}\` component, but also some other symbols that ` +
-                `are not in any \`@Component.deferredImports\` array. This renders all these ` +
+            `This import contains symbols that are used both inside and outside of the ` +
+                `\`@Component.deferredImports\` fields in the file. This renders all these ` +
                 `defer imports useless as this import remains and its module is eagerly loaded. ` +
-                `To fix this, make sure that this import contains *only* symbols ` +
-                `that are used within \`@Component.deferredImports\` arrays.`);
+                `To fix this, make sure that all symbols from the import are *only* used within ` +
+                `\`@Component.deferredImports\` arrays and there are no other references to those ` +
+                `symbols present in this file.`);
         diagnostics.push(diagnostic);
       }
       return {diagnostics};

diff --git a/packages/compiler-cli/test/ngtsc/local_compilation_spec.ts b/packages/compiler-cli/test/ngtsc/local_compilation_spec.ts
@@ -1529,15 +1529,13 @@ runInEachFileSystem(() => {
            // can not be removed.
            expect(diags.length).toBe(2);
 
-           const components = ['AppCmpA', 'AppCmpB'];
-           for (let i = 0; i < components.length; i++) {
-             const component = components[i];
+           for (let i = 0; i < 2; i++) {
              const {code, messageText} = diags[i];
              expect(code).toBe(ngErrorCode(ErrorCode.DEFERRED_DEPENDENCY_IMPORTED_EAGERLY));
              expect(messageText)
                  .toContain(
-                     'This import contains symbols used in the `@Component.deferredImports` ' +
-                     `array of the \`${component}\` component`);
+                     'This import contains symbols that are used both inside and outside ' +
+                     'of the `@Component.deferredImports` fields in the file.');
            }
          });
     });