Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image processing #23

Open
wants to merge 64 commits into
base: main
Choose a base branch
from
Open

Add image processing #23

wants to merge 64 commits into from

Conversation

emptyseth
Copy link
Member

  • Add image processing module
  • Move some common methods to the utils
  • Video module formatting
  • Update Readme and config

@emptyseth emptyseth requested a review from hom3chuk June 26, 2023 07:32
README.md Outdated

# image process/transcode location
location @luamp_image_process {
content_by_lua_file "/usr/local/openresty/nginx/nginx-lua-image.lua";
Copy link
Member

@hom3chuk hom3chuk Aug 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be media-processor.lua

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to push this 👍 Fixed.

README.md Outdated
set $luamp_postfix "";

#pass to transcoder location
try_files $uri @luamp_image_process;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs luamp_media_type var

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Member

@hom3chuk hom3chuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

upd: Waiting for the tests on an actual server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants