-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gatsby references #1431
Gatsby references #1431
Conversation
cb2c779
to
83048e9
Compare
await resetState(); | ||
}); | ||
|
||
test('@gatsby-build references', async ({ page }) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should have fallen on the test commit, yet it did not. I don't know why.
Locally it fails properly. But in CI an incremental Gatsby build sources all nodes for some reason.
Another evidence that we need to get rid of @amazeelabs/silverback-playwright
ASAP. Will do in a separate PR.
6e79a41
to
e87562a
Compare
This is needed for the future entity_usage integration. We will need to act before entity_usage updates its tracking data.
e87562a
to
e16f086
Compare
e16f086
to
129224b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So its not going to recursively update chains, right? Just the direct parent level. Should be good enough for the Gutenberg use case.
Yes, just direct parents. Still I'm a little concerned about the performance. What if we get an entity used in 1k other entities 🙈 Time will tell 😅 |
Package(s) involved
amazeelabs/silverback_gatsby
Description of changes
Whenever we track an update on an entity, get all its usages and track the source entities as well.
Motivation and context
gatsby-graphql-toolkit
creates node references in Gatsby data layer. Yet it does not clean them up when a target node is removed.https://github.com/gatsbyjs/gatsby-graphql-toolkit/blob/cec93fe2457aa0de64dbdeb759626010d9fe270a/src/source-nodes/node-actions/delete-nodes.ts#L17-L20
Related Issue(s)
#1274
How has this been tested?
Manually. Added an integration test case.