[동적계획법] 9월 27일 #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jk0527
approved these changes
Oct 3, 2022
Comment on lines
+17
to
+19
| ans = max_candy[n][m]; | ||
|
|
||
| return ans; |
Comment on lines
+28
to
+29
| vector<vector<int>> candy(n+1, vector<int>(m+1, 0)); | ||
| vector<vector<int>> max_candy(n+1, vector<int>(m+1, 0)); |
There was a problem hiding this comment.
더미 인덱스 사용하신 것 너무 좋습니다!! 새로 max_candy vector를 만들어도 되고 candy vector에 직접 더해도 됩니다!!
|
[추가제출 확인 완료] |
|
** P3 20923 코드 리뷰 완료** |
Dong-droid
reviewed
Oct 10, 2022
Comment on lines
32
to
37
| //for (int i = 0; i < do_ground.size(); i++) { | ||
| // su_card.push_back(do_ground.back()); | ||
| // do_ground.pop_back(); | ||
| //} | ||
| // �̷��� �ۼ��ߴµ� Ʋ�ȴ�. | ||
| // while ����� �ٲ��ִ� �¾Ҵµ� ���� ���̰� ���� �ڴ�. |
There was a problem hiding this comment.
do_ground.size() 는 계속 1씩 줄어듭니다
i는 반면에 계속 1씩 늘어납니다.
그러면, do_ground.size()와 i가 같아지는 순간이 생기게 되고,
이것은 do_ground에 있는 모든 카드를 pop해주지 않고 for문이 종료가 됩니다!!! 🐧
Dong-droid
reviewed
Oct 10, 2022
Comment on lines
+52
to
+65
| while (!su_ground.empty()) { | ||
| do_card.push_back(su_ground.back()); | ||
| su_ground.pop_back(); | ||
| } | ||
| while (!do_ground.empty()) { | ||
| do_card.push_back(do_ground.back()); | ||
| do_ground.pop_back(); | ||
| } | ||
| } | ||
|
|
||
| turn++; | ||
| } | ||
|
|
||
| // ��� |
There was a problem hiding this comment.
P3. 합쳐지는 카드 덱(des)과 합치는 카드 덱(src)만 다를 뿐 수연이와 도도가 종을 친 후에 동일한 일을 하고 있지 않나요?? ❓
그래서, des와 src를 매개변수로 하여 이를 함수화하면 더 좋을 것 같습니다!! 🦒 🐘
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
내용 & 질문
20055 번은 틀렸지만 어디가 잘못된건지 잘 모르겠습니다. 첨삭을 부탁드려도 될까요?
20923 번에 for문으로 작성하였다가 while문으로 수정하여 맞았던 부분이 있는데(주석에 표시해두었습니다) 이 둘이 어떻게 다른지 잘 모르겠습니다.
<기존 제출>
<추가 제출>