Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Webview height for TokenCards #3326

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Fix Webview height for TokenCards #3326

merged 1 commit into from
Oct 12, 2023

Conversation

JamesSmartCell
Copy link
Member

Fixes issue where webview height in the tokencard view* was way too long.

  • NFT Detail where there's a TokenScript with a Token Card view.

@github-actions
Copy link

Pull reviewers stats

Stats of the last 30 days for alpha-wallet-android:

User Total reviews Time to review Total comments

@codecov
Copy link

codecov bot commented Oct 12, 2023 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Files Coverage Δ
...com/alphawallet/app/ui/NFTAssetDetailActivity.java 0.00% <0.00%> (ø)

📢 Thoughts on this report? Let us know!.

@JamesSmartCell JamesSmartCell merged commit abd3a7f into master Oct 12, 2023
8 checks passed
@JamesSmartCell JamesSmartCell deleted the fix-tokencard-webview-height branch October 12, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JamesSmartCell