Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add protection for raw sign #3288

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Add protection for raw sign #3288

merged 2 commits into from
Sep 11, 2023

Conversation

JamesSmartCell
Copy link
Member

Add protection for raw signing and sign override.

@github-actions
Copy link

Pull reviewers stats

Stats of the last 30 days for alpha-wallet-android:

User Total reviews Time to review Total comments

@codecov
Copy link

codecov bot commented Sep 10, 2023

Codecov Report

Patch has no changes to coverable lines.

❗ Current head b063bed differs from pull request most recent head 21d287d. Consider uploading reports for the commit 21d287d to get more accurate results

Files Changed Coverage
...let/app/repository/SharedPreferenceRepository.java 0.00%
...m/alphawallet/app/ui/AdvancedSettingsActivity.java 0.00%
.../src/main/java/com/alphawallet/app/util/Utils.java 0.00%
...allet/app/viewmodel/AdvancedSettingsViewModel.java 0.00%
...tconnect/WalletConnectV2SessionRequestHandler.java 0.00%
.../alphawallet/app/widget/ActionSheetSignDialog.java 0.00%
...ava/com/alphawallet/app/widget/SignDataWidget.java 0.00%

📢 Thoughts on this report? Let us know!.

@JamesSmartCell JamesSmartCell merged commit 7efdb1e into master Sep 11, 2023
6 checks passed
@JamesSmartCell JamesSmartCell deleted the improve-signing-security branch September 11, 2023 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant