Add support for I2C Realtime Clocks #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on to support additional clocks, including NTP servers (in theory)
…nter is fine with). Re-order methods inside the RealtimeClock class
…ting the time. Move some code around, add a __str__ function to the clock class so we can print the time with print(clock). Add some supporting data structures to get the name of the weekday or month. Validate the datetime tuple before setting the clock.
benjaminvdb
reviewed
Jan 6, 2025
…lasses, add enum-like constants for their integer equivalents. Remove subseconds from the null clock. Remove references to local time offsets from docstrings
… then shift the datetime fields over it to reduce seed collisions
…ngs organized. Tweak the seeds to further reduce collisions
chrisib
added
firmware
…goWonk a little bit
…in the current month & year, is_leap_year flag. Static methods renamed. Fix a bug in the wonk generation that could result in out-of-bounds errors
…y update time, or for midnight; otherwise use UTC
…nces of synchronization between them
…y're the same negative length adjustment they won't be wholly synchronized
…) with randomness
…ns and only 1 special phase per cycle. Fix a bug where we accidentally swapped waning for waxing in the phase calculations
|
This is a big one. Very impressive! 🙇 I'm still waiting for my RTC module and I'm hoping to give it a test run soon. Thanks! |
|
i have two installed here, works like a charm. have a script done already that i'll upload soon... |
That's great! I'm glad it's working for people who aren't me.
I'm planning on merging this feature into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new experimental module to add realtime clock support. Currently testing with a DS3231 module, though the DS1307 should also be compatible.
I'll add an additional contrib script or two that actually make use of this feature before marking this as ready for review. Likely something inspired by Pet Rock and/or Almanac, as both of those make good use of RTC capabilities.