-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added the navbar in the practicedsa.html #221
base: master
Are you sure you want to change the base?
Conversation
@harikesh409 sir can you please review it . |
<header class="fix"> | ||
|
||
<nav class="navbar navbar-expand-lg navbar-dark fixed-top nav-col"> | ||
<a class="navbar-brand" href="#"><img src="images/icon.png" alt="Algo Phantoms" width="50px" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
link this to index.html
@harikesh409 ok sir I am going to fix these as you said . |
@harikesh409 sir now is it in correct form ? |
@lipsa199 resolve the merge conflicts. |
Done sir @harikesh409 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are the bootstrap styles removed it just messed up the navbar.
practicedsa.html
Outdated
@@ -25,11 +32,65 @@ | |||
|
|||
} | |||
</style> | |||
<script> | |||
window.onload = function () { | |||
var preloader = document.getElementById("preloader") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no element with id preloader so either add the element or remove this.
Check your self before asking for review. |
@harikesh409 sorry sir , I am working on it . |
@harikesh409 sir i donot understand the conflict issue can you please help me with this? |
there are few changes missing in your local so it is causing conflicts, if you don't know how to sync a forked repo please refer this: https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/syncing-a-fork
|
hey @harikesh409 I added the navbar section and linked the index.html to home in the practicedsa.html page issue-214 .