Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solved issue regarding local_settings.py file not found #30

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

solved issue regarding local_settings.py file not found #30

wants to merge 7 commits into from

Conversation

patilkrunal
Copy link

@patilkrunal patilkrunal commented Mar 14, 2021

Related Issue

  • Error about local_settings.py not found during initial setup of project

Closes: #5

Describe the changes you've made

  • Added steps in README.md of how to setup local_settings.py file for local system and to ignore it in .gitignore
  • moved relevant settings.py settings to local_settings.py file like secret_key, database configuration, email host configurations

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.

@patilkrunal patilkrunal changed the title settings files modified and added relavant info in readme solved issue regarding local_settings.py file not found Mar 14, 2021
@patilkrunal
Copy link
Author

patilkrunal commented Mar 14, 2021

Maintainers (@diyajaiswal11) please add the gssoc21 tag to issue #5. Also if you could assign it to me and then merge my PR it will help me to progress in gssoc21.
Suggest any changes if needed.

Copy link
Collaborator

@harsh7in harsh7in left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have removed the secret key, debug, allowed host from settings.py so it will create another error which will take time to set up for other users.

@patilkrunal
Copy link
Author

I've mentioned how to create local_settings.py file while setting up the project before makemigrations. And have copy pasted these secret_key, database config, email config in readme.me. so the one who will setup might follow it properly.

And if local_settings.py is included and not put in .gitignore then that will have no impact of creating another local_settings.py differently.

@hmangukia
Copy link
Collaborator

Hey @patilkrunal, let's wait on out project admin's review on this. Till then, can you solve the merge conflicts? Thanks! 😄

@patilkrunal
Copy link
Author

resolved.
Also local_settings.py was put inorder to have private information on localmachine itself and not in public. so it will be better to include local_settings.py file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ModuleNotFoundError: No module named 'AlgoPhantomBackend.local_settings'
5 participants