[ACS-4749] add button is enabled for comment contains only spaces #10577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AleksanderSklorz
requested review from
nikita-web-ua,
swapnil-verma-gl,
MichalKinas and
dominikiwanekhyland
AleksanderSklorz
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
nikita-web-ua
approved these changes
Jan 24, 2025
MichalKinas
approved these changes
Jan 28, 2025
| display: none; | ||
| &#{$mat-form-field-invalid} { | ||
| #{$mat-input-element} { | ||
| &::placeholder { |
There was a problem hiding this comment.
I think you don't have to repeat this line to set the color if you use this selector:
Suggested change
| &::placeholder { | |
| &::placeholder, | |
| &:focus::placeholder { |
AleksanderSklorz
force-pushed
the
ACS-4749-Add-button-is-enabled-for-comment-contains-only-spaces
branch
from
cdcc348 to
afd787e
Compare
|
AleksanderSklorz
deleted the
ACS-4749-Add-button-is-enabled-for-comment-contains-only-spaces
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://hyland.atlassian.net/browse/ACS-4749
What is the new behaviour?
Add button for comment is disabled when comment contains only spaces.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: