Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AAE-29971 Buttons for dynamic component #10539

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

tomaszhanaj
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?
https://hyland.atlassian.net/browse/AAE-29971

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@eromano
Copy link
Contributor

eromano commented Jan 10, 2025

@tomaszhanaj can we add some unit test?

@@ -1 +1,8 @@
<div #container></div>
<mat-card>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can Dedicated Screens be rendered without a mat-card? Intention of Dedicated Screens would be more of a full screen complex screen. I don't have a strong opinion on this but a point to consider.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried solution without mat-card. This is how it looks
image
and this is with mat-card
image
and I think that there is no big difference. Mat-card is used for all tasks. Workflow for tasks is like: show it within table and when the user wants it to be fullscreen, there is a button to do it. So your component needs to provide function to make component fullscreen and it should fit space that is left by parent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants