[ACS-8818] Mime type icons are now updated with file names in the viewer #10506
Conversation
swapnil-verma-gl
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
swapnil-verma-gl
requested review from
nikita-web-ua,
MichalKinas,
AleksanderSklorz and
dominikiwanekhyland
and removed request for
DenysVuika,
eromano and
popovicsandras
|
| @@ -348,13 +349,11 @@ export class AlfrescoViewerComponent implements OnChanges, OnInit { | |||
|
|
|||
| const nodeMimeType = nodeData?.content?.mimeType; | |||
| const renditionMimeType = nodeRendition.mimeType; | |||
| mimeType = renditionMimeType || nodeMimeType; | |||
| this.mimeType = renditionMimeType || nodeMimeType; | |||
There was a problem hiding this comment.
Can we cover that with some small unit test case check?
There was a problem hiding this comment.
I'm not sure if a unit test would make a difference here really. If you see in the earlier code, this.mimetype would have anyways gotten updated in the same function execution in line num 357. We only added an assignment earlier in the function execution to make sure it gets updated in the same change detection cycle as the file name.
There was a problem hiding this comment.
I think with #10508 this PR might be obsolete, currently when renditions are generated with this approach the icon is changed twice and ultimately is not correct, the other fixes both issues
|
A quick test shows that the fixes in #10508 also fix the issues in this PR and ticket. Therefore, this PR is no longer needed and is obsolete. Closing this PR |
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
When switching between files from within the viewer, there was case where the file icon would load a split second after the file name was changed
What is the new behaviour?
File icon and name are now changed simultaneously
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
https://hyland.atlassian.net/browse/ACS-8818