-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ipv4 connection type sensor #134
base: main
Are you sure you want to change the base?
Conversation
@karlsvenssonn Hi. Thank you for your PR. Unfortunately, it brakes compatibilities with routers that doesnt have ipv4 status Could you add swedish translation in a different PR please? In this PR we will think what to do with ipv4 status |
Yes, I can fix that. I think I have a solution to exclude it for routers that don't have ipv4_status as well. Give me some days to come up with a proposal for solution. Will create a new PR for Swedish meanwhile. |
Latest changes should make it compatible with routers without ipv4_status. One thing to consider is if it's always Might be better to change to |
@karlsvenssonn Is there a way to make new sensor disabled for those who doesn't have this option? It would be better then set Unavailable |
Yes, the sensor is now disabled by default. |
@AlexandrErohin Take a look at latest changes, the sensor should Only be enabled if |
@karlsvenssonn Have you test these changes? |
@AlexandrErohin I have tested with my MR600 router, but when simulating a router without ipv4 I got some problems. |
@AlexandrErohin I'm now happy with the functionality. If the router client supports I have removed the |
@AlexandrErohin Good suggestions, i have separated status sensors and ipv4 sensors. I decided to do a similar setup for ipv4_sensors, this makes it easy to add additional sensors from ipv4_status if wanted. |
Add sensor for ipv4 connection type.
Good to check if 4G router is connected to WAN or 4G
I'm in no means an expert, this is my first change to a custom_components. It seems to work but I might have done something incorrect.
Also includes swedish translation