Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add initial implementation for the @trace decorator #1136

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

avaxaleph
Copy link
Contributor

Description

Added support for @trace decorator that can be used with any method inside a Task without the need to pass task_span.

Before Merging

  • Review the code changes
    • Unused print / comments / TODOs
    • Missing docstrings for functions that should have them
    • Consistent variable names
    • ...
  • Update changelog.md if necessary
  • Commit messages should contain a semantic label and the ticket number
    • Consider squashing if this is not the case

Copy link
Contributor

@maxhammeralephalpha maxhammeralephalpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @avaxaleph
can you please add tests and an .ipynb notebook that showcases how you can use the @trace decorator and submit it to Studio?

Another question I have is regarding how the decorator interacts with the tracer that you pass to the run method?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants