Common config with fragments #344
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nnectors Signed-off-by: Aindriu Lavelle <[email protected]>
Signed-off-by: Aindriu Lavelle <[email protected]>
Signed-off-by: Aindriu Lavelle <[email protected]>
…ector use the sink source for configuration Signed-off-by: Aindriu Lavelle <[email protected]>
Signed-off-by: Aindriu Lavelle <[email protected]>
Add config fragments
Signed-off-by: Aindriu Lavelle <[email protected]>
File name fragment tests
Signed-off-by: Aindriu Lavelle <[email protected]>
* fixed test issues and updated javadoc * removed unnecessary RecordGrouperFactory changes --------- Co-authored-by: ¨Claude <¨[email protected]¨>
Signed-off-by: Aindriu Lavelle <[email protected]>
aindriu-aiven
force-pushed
the
aindriu-aiven/common-config-with-fragments
branch
from
9713291
to
b194f7b
Compare
Claudenw
requested changes
Nov 14, 2024
commons/src/main/java/io/aiven/kafka/connect/common/config/CommonConfig.java
Show resolved
Hide resolved
commons/src/main/java/io/aiven/kafka/connect/common/config/OutputFormatFragment.java
Show resolved
Hide resolved
commons/src/main/java/io/aiven/kafka/connect/common/config/SinkCommonConfig.java
Show resolved
Hide resolved
s3-commons/src/main/java/io/aiven/kafka/connect/config/s3/S3ConfigFragment.java
Outdated
Show resolved
Hide resolved
s3-commons/src/main/java/io/aiven/kafka/connect/config/s3/S3CommonConfig.java
Outdated
Show resolved
Hide resolved
s3-commons/src/main/java/io/aiven/kafka/connect/config/s3/S3CommonConfig.java
Outdated
Show resolved
Hide resolved
s3-commons/src/main/java/io/aiven/kafka/connect/iam/AwsCredentialProviderFactory.java
Outdated
Show resolved
Hide resolved
aindriu-aiven
force-pushed
the
aindriu-aiven/common-config-with-fragments
branch
2 times, most recently
from
16cc8e3
to
66816f9
Compare
|
@RyanSkraba @AnatolyPopov would you be able to take a look ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AivenCommonConfig
Has common Configuration in S3SinkBaseConfig and S3SourceBaseConfig
Includes some config loader methods that are common to both for AWS STS and S3 Retry Policies
Updates the S3 Sink Connector to use the s3-common lib
Added deprecated config & a separate method to load into config so S3 Sink can decide when to remove deprecated config
Config Fragments introduced to help split code between Sink and Source while reducing duplication.
Addition of a new module/project to allow the sharing of common code between S3 Sink and Source
Handles Creation of S3 Aws client
Refactors commons AivenCommonConfig and splits into a common config and a Sink and Source config, deprecating the
This was built on top of this smaller branch aindriu-aiven/split-common-s3-config