Integration tests clean up #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| connectorConfig.put(INPUT_FORMAT_KEY, parquet.getValue()); | ||
| connectorConfig.put(SCHEMA_REGISTRY_URL, schemaRegistry.getSchemaRegistryUrl()); | ||
| connectorConfig.put("value.converter", "io.confluent.connect.avro.AvroConverter"); | ||
| connectorConfig.put(valueConverterSchemaRegistryUrl, schemaRegistry.getSchemaRegistryUrl()); |
There was a problem hiding this comment.
Suggested change
| connectorConfig.put(valueConverterSchemaRegistryUrl, schemaRegistry.getSchemaRegistryUrl()); | |
| connectorConfig.put("value.converter.schema.registry.url", schemaRegistry.getSchemaRegistryUrl()); |
There was a problem hiding this comment.
or VALUE_CONVERTER_SCHEMA_REGISTRY_URL
There was a problem hiding this comment.
Huh, thanks, missed that. Good catch!
muralibasani
requested changes
Nov 13, 2024
AnatolyPopov
force-pushed
the
anatolii/integration-tests-improvements
branch
from
7152f73
to
5a13efb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some clean up of integration tests + fixes for comments that were not addressed in previous PRs