Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AsyncWebServer version pin #4142

Merged
merged 1 commit into from
Sep 14, 2024

Conversation

willmmiles
Copy link
Collaborator

We want to always use the tagged version, not complain if the current main is a mismatch.

@blazoncek
Copy link
Collaborator

Does not work on my system.

warning: Could not find remote branch 2.2.1 to clone.
fatal: Remote branch 2.2.1 not found in upstream origin

@blazoncek
Copy link
Collaborator

I guess we'll need to go with 2.3.0 in main.

@willmmiles
Copy link
Collaborator Author

I'm not sure h

Does not work on my system.

warning: Could not find remote branch 2.2.1 to clone.
fatal: Remote branch 2.2.1 not found in upstream origin

That's definitely not right - this PR sets the target to the version tag ("v2.2.1"), not "2.2.1". The CI seems to build correctly.

@blazoncek blazoncek merged commit 0806c7f into Aircoookie:0_15 Sep 14, 2024
20 checks passed
@willmmiles willmmiles mentioned this pull request Sep 14, 2024
1 task
softhack007 pushed a commit to MoonModules/WLED that referenced this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants