-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WireGuard VPN usermod #3270
Conversation
Is there any chance someone could take a quick look at this? Thank you all! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no way of testing it so I trust it works for you.
There are some things I'd like you to address before merging, though.
One more thing: Please add your contact info into readme.md for user reference in case someone needs help with usermod. |
Can you look at the changes I made? |
Using char[xx] eats a lot of stack, which is limited on MCU. Otherwise I see you updated as requested and see no objection to this usermod. |
fixed |
Are you sure this works? I may have unintentionally mislead you when I suggested |
Oops, ok. I'll take a look at fixing it tomorrow. |
Hmm, correct me if I'm wrong, but since these keys are private members, they are created on the heap anyways as the usermod constructor is called in |
All good, thanks for the input. I went ahead and reverted my branch back to that commit and then merged in all the changes from |
You are correct and I was wrong. Mea culpa. |
All good :) I'd say this is ready to merge! |
Adds a WireGuard usermod for ESP32 that allows WLED devices to join a remote network in situations where wireless isolation prevents local control.