Fixed indexing error from no surface detection. Added test (#16)

study_lyte/detect.py

@@ -113,6 +113,7 @@ def get_signal_event(signal_series, threshold=0.001, search_direction='forward',
         # if event_idx == 0:
         #     event_idx = None
 
+
     return event_idx
 
 
@@ -201,6 +202,10 @@ def get_nir_surface(clean_active, threshold=-1, max_threshold=0.25):
     # Detect likely candidate normal ambient conditions
     surface = get_signal_event(neutral, search_direction='forward', threshold=threshold,
                                max_threshold=max_threshold, n_points=n)
+    # No surface found and all values met criteria
+    if surface == len(neutral)-1:
+        surface = 0
+
     return surface
 
 

study_lyte/profile.py

@@ -170,12 +170,14 @@ def nir(self):
             Retrieve the Active NIR sensor with ambient NIR removed
             """
             if self._nir is None:
-                self._nir = self.raw[["Sensor2","Sensor3", "nir"]]
+                self._nir = self.raw[["Sensor2", "Sensor3", "nir"]]
                 self._nir['depth'] = self.depth.values
                 end = self.stop.index if self.ground.index is None else self.ground.index
+
                 self._nir = self._nir.iloc[self.surface.nir.index:end].reset_index()
                 self._nir = self._nir.drop(columns='index')
                 self._nir['depth'] = self._nir['depth'] - self._nir['depth'].iloc[0]
+
             return self._nir
 
         @property
@@ -306,7 +308,8 @@ def surface(self):
             if self._surface is None:
                 # Call to populate nir in raw
                 idx = get_nir_surface(self.raw['nir'])
-
+                if idx == 0:
+                    LOG.warning("Unable to find snow surface, defaulting to first data point")
                 # Event according the NIR sensors
                 depth = self.depth.iloc[idx]
                 nir = Event(name='surface', index=idx, depth=depth, time=self.raw['time'].iloc[idx])