Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAY-5702: Adds docs for the updated vault feature in Payment Services #386

Merged
merged 48 commits into from
Dec 19, 2024

Conversation

danidelcar
Copy link
Contributor

Purpose of this pull request

This pull request (PR) adds docs for the updated vault feature in Payment Services. Created a new vault folder in the GraphQL schema with new queries and mutations.

Affected pages

  • ...

Links to Magento Open Source code

  • ...

Additional info

PAY-5702

@danidelcar danidelcar added the enhancement New feature or request label Dec 13, 2024
@danidelcar danidelcar self-assigned this Dec 13, 2024
@danidelcar
Copy link
Contributor Author

PR still in draft mode because I'm still missing some input/output attribute details to be clarified

@danidelcar danidelcar marked this pull request as ready for review December 16, 2024 10:35
@danidelcar danidelcar requested a review from virfaure December 16, 2024 10:35
@danidelcar danidelcar requested a review from virfaure December 16, 2024 12:49
@@ -0,0 +1,15 @@
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Rename the directory to payment-services.
  2. Move the existing Payment Services queries and mutations to this new directory.
  3. Update the TOC file to include these new queries/mutations and the files you moved.
  4. Also update the index files under the checkout directory to point to this new index file.
  5. Create a DEVSITE Jira ticket to enable redirection. You can use DEVSITE-956 as template.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why we would move mutations and queries related to the checkout process to this folder. Vault existed before, now simply it has more features, thus new query and mutations, that are related to vaulting without a purchase, that is, outside of a checkout process, see credit card vaulting in PS

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied a huge restructure for the payment services extension, might be the only thing needed is redirects

src/pages/graphql/schema/vault/index.md Outdated Show resolved Hide resolved
src/pages/graphql/schema/vault/index.md Outdated Show resolved Hide resolved
src/pages/graphql/schema/vault/index.md Outdated Show resolved Hide resolved
src/pages/graphql/schema/vault/queries/getVaultConfig.md Outdated Show resolved Hide resolved
src/pages/graphql/schema/vault/queries/getVaultConfig.md Outdated Show resolved Hide resolved
src/pages/graphql/schema/vault/queries/getVaultConfig.md Outdated Show resolved Hide resolved
src/pages/graphql/schema/vault/queries/getVaultConfig.md Outdated Show resolved Hide resolved
src/pages/graphql/schema/vault/queries/getVaultConfig.md Outdated Show resolved Hide resolved
danidelcar and others added 12 commits December 17, 2024 12:03
@danidelcar
Copy link
Contributor Author

Applied most of the suggestions @keharper , but I have a couple of questions regarding TOC and structure. Please take a look when you can, thanks!

@danidelcar
Copy link
Contributor Author

Please @virfaure @keharper take a look at the changes in the PR, thanks!

Copy link

@virfaure virfaure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good job

@danidelcar danidelcar merged commit ae6507d into main Dec 19, 2024
18 checks passed
@danidelcar danidelcar deleted the del-PAY-5702-vault branch December 19, 2024 13:58
@danidelcar
Copy link
Contributor Author

merged!, thanks @virfaure & @keharper for the help and reviews!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants