-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PAY-5702: Adds docs for the updated vault feature in Payment Services #386
Conversation
PR still in draft mode because I'm still missing some input/output attribute details to be clarified |
src/pages/graphql/schema/vault/mutations/createVaultCardPaymentToken.md
Outdated
Show resolved
Hide resolved
src/pages/graphql/schema/vault/mutations/createVaultCardPaymentToken.md
Outdated
Show resolved
Hide resolved
src/pages/graphql/schema/checkout/mutations/create-payment-order.md
Outdated
Show resolved
Hide resolved
@@ -0,0 +1,15 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Rename the directory to
payment-services
. - Move the existing Payment Services queries and mutations to this new directory.
- Update the TOC file to include these new queries/mutations and the files you moved.
- Also update the index files under the
checkout
directory to point to this new index file. - Create a DEVSITE Jira ticket to enable redirection. You can use DEVSITE-956 as template.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why we would move mutations and queries related to the checkout process to this folder. Vault existed before, now simply it has more features, thus new query and mutations, that are related to vaulting without a purchase, that is, outside of a checkout process, see credit card vaulting in PS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied a huge restructure for the payment services extension, might be the only thing needed is redirects
…er.md Co-authored-by: Kevin Harper <[email protected]>
Co-authored-by: Kevin Harper <[email protected]>
Co-authored-by: Kevin Harper <[email protected]>
Co-authored-by: Kevin Harper <[email protected]>
Co-authored-by: Kevin Harper <[email protected]>
Co-authored-by: Kevin Harper <[email protected]>
Co-authored-by: Kevin Harper <[email protected]>
Co-authored-by: Kevin Harper <[email protected]>
…tToken.md Co-authored-by: Kevin Harper <[email protected]>
…oken.md Co-authored-by: Kevin Harper <[email protected]>
…tToken.md Co-authored-by: Kevin Harper <[email protected]>
…tToken.md Co-authored-by: Kevin Harper <[email protected]>
…oken.md Co-authored-by: Kevin Harper <[email protected]>
…oken.md Co-authored-by: Kevin Harper <[email protected]>
…oken.md Co-authored-by: Kevin Harper <[email protected]>
…oken.md Co-authored-by: Kevin Harper <[email protected]>
…oken.md Co-authored-by: Kevin Harper <[email protected]>
Applied most of the suggestions @keharper , but I have a couple of questions regarding TOC and structure. Please take a look when you can, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Good job
src/pages/graphql/payment-services-extension/mutations/create-payment-order.md
Outdated
Show resolved
Hide resolved
src/pages/graphql/payment-services-extension/mutations/create-payment-order.md
Outdated
Show resolved
Hide resolved
src/pages/graphql/payment-services-extension/mutations/create-payment-order.md
Outdated
Show resolved
Hide resolved
src/pages/graphql/payment-services-extension/mutations/create-payment-order.md
Outdated
Show resolved
Hide resolved
src/pages/graphql/payment-services-extension/mutations/create-vault-card-payment-token.md
Outdated
Show resolved
Hide resolved
src/pages/graphql/payment-services-extension/mutations/create-vault-card-payment-token.md
Outdated
Show resolved
Hide resolved
src/pages/graphql/payment-services-extension/mutations/create-vault-card-setup-token.md
Outdated
Show resolved
Hide resolved
src/pages/graphql/payment-services-extension/queries/get-payment-config.md
Outdated
Show resolved
Hide resolved
src/pages/graphql/payment-services-extension/queries/get-vault-config.md
Outdated
Show resolved
Hide resolved
…payment-order.md Co-authored-by: Kevin Harper <[email protected]>
…payment-order.md Co-authored-by: Kevin Harper <[email protected]>
Purpose of this pull request
This pull request (PR) adds docs for the updated vault feature in Payment Services. Created a new vault folder in the GraphQL schema with new queries and mutations.
Affected pages
Links to Magento Open Source code
Additional info
PAY-5702