Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add uniq function to embedded lodash library #3429

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

jfmitchell
Copy link
Contributor

The composite multifield widget relies on the uniq function - so this adds it. Still based on v4.17.21

@kwin
Copy link
Contributor

kwin commented Sep 11, 2024

@jfmitchell Can you add an issue which describes describe where and how this error manifests itself? The changelog is supposed to reference issues (not PRs) to give some more written context.

@cxc38
Copy link

cxc38 commented Sep 13, 2024

@kwin the Lodash lib was upgraded from 4.17.15 to 4.17.21 during the 6.3.4 release. During the upgrade, the Lodash lib was rebuilt for 4.17.21. Lodash lib can have core build, full build, and custom build. 4.17.15 embedded in acs-aem-common 6.3.2 was a full build. However, the embedded 4.17.21 lib is just a core build, which has minimum functions in it. It missed some functions which are required by multifields widget, typically the uniq() function in Array category. This caused the form using multifields widget failed to populate the content when we upgraded the acs-aem-common to 6.6.2 from a older version. I believe it affects all acs-aem-common releases since 6.3.4.

@davidjgonzalez davidjgonzalez added this to the 6.7.0 milestone Oct 1, 2024
@davidjgonzalez davidjgonzalez merged commit a6d8161 into Adobe-Consulting-Services:master Oct 1, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants