Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config option to change server port #17

Open
wants to merge 1 commit into
base: http-plugin
Choose a base branch
from
Open

Add config option to change server port #17

wants to merge 1 commit into from

Conversation

kmarius
Copy link

@kmarius kmarius commented Sep 25, 2020

I wasn't sure if startUp should throw an exception if it fails. I just throw the last exception if none of the ports work.

@Adam-
Copy link
Owner

Adam- commented Sep 25, 2020

Any reason this is a list of ports and not just one port?

@kmarius
Copy link
Author

kmarius commented Sep 25, 2020

I run several clients with the same config. This makes sure each of them gets a free port.

@Adam-
Copy link
Owner

Adam- commented Sep 25, 2020

Does that make sense? You wouldn't be able to tell which client got which port so why is that useful?

@kmarius
Copy link
Author

kmarius commented Sep 26, 2020

I want to share the overwhelming majority of settings between my accounts, hence I only use one config. This way I can actually just switch accounts in OSRS without starting a new RL instance or logging to a different account. Right now I can only distinguish the accounts via API by their stats; I think it would make sense to expose the account name through the API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants