Monica Cruz - Maple C16 #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyra-patton
reviewed
Jul 15, 2022
There was a problem hiding this comment.
✨🍵🧋 Nice work Monica! Really not sure what happened to my initial review, but it does look like you hit the learning goals. I left a couple comments about code style and opportunities for refactoring you can review below. Let me know what questions you have.
🟢
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| # Time Complexity: O(1) | ||
| # Space Complexity: O(1) | ||
| def get_first(self): |
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| # Time Complexity: O(1) | ||
| # Space Complexity: O(1) | ||
| def add_first(self, value): |
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def search(self, value): |
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def length(self): |
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def get_at_index(self, index): |
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def add_last(self, value): |
Comment on lines
+124
to
+130
| while current_node.next: | ||
| if current_node.value > max_value: | ||
| max_value = current_node.value | ||
| current_node = current_node.next | ||
|
|
||
| if current_node.value > max_value: | ||
| max_value = current_node.value |
There was a problem hiding this comment.
Suggested change
| while current_node.next: | |
| if current_node.value > max_value: | |
| max_value = current_node.value | |
| current_node = current_node.next | |
| if current_node.value > max_value: | |
| max_value = current_node.value | |
| while current_node: | |
| if current_node.value > max_value: | |
| max_value = current_node.value | |
| current_node = current_node.next | |
| current_node = current_node.next | ||
|
|
||
| # When last node is found, I want to append new_node to it. | ||
| current_node.next = new_node | ||
|
|
||
| # method to return the max value in the linked list | ||
| # returns the data value and not the node | ||
| def find_max(self): |
There was a problem hiding this comment.
✨ See code style suggestion below!
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def delete(self, value): |
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def reverse(self): |
There was a problem hiding this comment.
✨ Very creative solution! If you wanted to refactor, think about how you might be able to do this with just one traversal of the list (one while loop). Hint: Pointers will play a big part!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.