Kunzite: G Quinn #109
Kunzite: G Quinn #109
Conversation
| @@ -1,11 +1,127 @@ | |||
| import random | |||
There was a problem hiding this comment.
Good idea to add a line break between the imports and functions in a file like this.
| def draw_letters(): | ||
| pass | ||
| letters =[] | ||
| LETTER_POOL = { |
There was a problem hiding this comment.
This dictionary could be moved outside this function into the main scope of the module so that draw_letters doesn't need to recreate this dictionary every time the function is run.
| letter = random.choice(list(LETTER_POOL)) | ||
| if LETTER_POOL[letter] > 0: | ||
| LETTER_POOL[letter] -= 1 | ||
| else: |
There was a problem hiding this comment.
One suggestion - rather than have an else block that skips the append operation on line 39, why not just append within the if block?
|
|
||
| def uses_available_letters(word, letter_bank): | ||
| pass | ||
| new_word=word.upper() |
There was a problem hiding this comment.
Careful with the spacing, should have space on either side of the equals sign in Python variable assignments:
new_word = word.upper()| pass | ||
| new_word=word.upper() | ||
| letter_bank_copy =list(letter_bank) | ||
| for letter in new_word: |
There was a problem hiding this comment.
This works perfectly well, but could be simplified a bit:
for letter in word.upper():
if letter in letter_bank_copy:
letter_bank_copy.remove(letter)
else:
return False
return True| maximum = scores_dict[scores] | ||
| max_key = scores | ||
| #Line 111 & 112 doesn't work if there are 3 or more words that are the same length |
There was a problem hiding this comment.
Still, this is close and passes the tests. Great job identifying where code can be improved.
|
|
||
| # how can I do this using max()? | ||
| # I originally had this but didn't how how to break ties according to len() using max(). |
There was a problem hiding this comment.
You'd probably need some additional conditional logic to make use of max in that way. There are a lot of different ways to accomplish the same solution, you'll see that time and again in programming!
No description provided.