Water - Jessica #51
Open
Water - Jessica #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Media Ranker
Functional Requirements: Manual Testing
| Criteria | yes/no |
|---|---|
| Before logging in | -- |
| 1. On index page, there are at most 10 pieces of media on three lists, and a Media Spotlight | ✔️ |
| 2. Can go into a work's show page | ✔️ |
| 3. Verify unable to vote on a work, and get a flash message | ✔️ |
| 4. Can edit this work successfully, and get a flash message | ✔️ |
| 5. Can go to "View all media" page and see three lists of works, sorted by vote | Works should be separated by category. Votes are not displayed on this page, so it's hard to see that they're sorted by vote. |
| 6. Verify unable to create a new work when the form is empty, and details about the validation errors are visible to the user through a flash message | ✔️ |
| 7. Can create a new work successfully. Note the URL for this work's show page | ✔️ |
| 8. Can delete this work successfully | ✔️ |
| 9. Going back to the URL of this deleted work's show page produces a 404 or some redirect behavior (and does not try to produce a broken view) | ✔️ Good use of a flash message |
| 10. Verify that the "View all users" page lists no users | ✔️ |
| Log in | -- |
| 11. Logging in with a valid name changes the UI to "Logged in as" and "Logout" buttons | ✔️ |
| 12. Your username is listed in "View all users" page | ✔️ |
| 13. Verify that number of votes determines the Media Spotlight | ✔️ |
| 14. Voting on several different pieces of media affects the "Votes" tables shown in the work's show page and the user's show page | ✔️ |
| 15. Voting on the same work twice produces an error and flash message, and there is no extra vote | ✔️ |
| Log out | -- |
| 16. Logging out showed a flash message and changed the UI | ✔️ |
| 17. Logging in as a new user creates a new user | ✔️ |
| 18. Logging in as an already existing user has a specific flash message | ✔️ |
Major Learning Goals/Code Review
| Criteria | yes/no |
|---|---|
| 1. Sees the full development cycle including deployment, and the app is deployed to Heroku | Not deployed - ok |
| 2. Practices full-stack development and fulfilling story requirements: the styling, look, and feel of the app is similar to the original Media Ranker | I like the styling, but you're missing the columns for the homepage. |
| 3. Practices git with at least 25 small commits and meaningful commit messages | ✔️ |
Previous Rails learning, Building Complex Model Logic, DRYing up Rails Code
| Criteria | yes/no |
|---|---|
4. Routes file uses resources for works |
✔️ |
| 5. Routes file shows intention in limiting routes for voting, log-in functionality, and users | ✔️ |
| 6. The homepage view, all media view, and new works view use semantic HTML | ✔️ |
| 7. The homepage view, all media view, and new works view use partials when appropriate | See in-line comment |
8. The model for media (likely named work.rb) has_many votes |
✔️ |
| 9. The model for media has methods to describe business logic, specifically for top ten and top media, possibly also for getting works by some category | ✔️ |
10. Some controller, likely the ApplicationController, has a controller filter for finding a logged in user |
See in-line comment |
11. Some controller, likely the WorksController, has a controller filter for finding a work |
✔️ |
12. The WorksController uses strong params |
✔️ |
13. The WorksController's code style is clean, and focused on working with requests, responses, params, session, flash |
✔️ |
Testing Rails Apps
| Criteria | yes/no |
|---|---|
| 14. There are valid fixtures files used for users, votes, and works | Not fixtures for votes |
| 15. User model has tests with sections on validations (valid and invalid) and relationships (has votes) | ✔️ |
| 16. Vote model has tests with sections on validations (valid and invalid) and relationships (belongs to a user, belongs to a vote) | ✔️ |
| 17. Work model has tests with sections on validations (valid and invalid) and relationships (has votes) | ✔️ |
| 18. Work model has tests with a section on all business logic methods in the model, including their edge cases | ✔️ |
Overall Feedback
Good work overall on media ranker. It is clear that the learning goals around working with session and flash, using test fixtures, and writing model methods were met.
With bEtsy, I encourage you to spend time seeing how loops and partial views can DRY up your view code. In addition, spend time understanding how controller filters in the application controller work.
I've left a few in-line comments for you to review. Please let me know if you have any questions. Keep up the hard work!
| Overall Feedback | Criteria | yes/no |
|---|---|---|
| Green (Meets/Exceeds Standards) | 14+ in Functional Requirements: Manual Testing && 14+ in Code Review | ✔️ |
| Yellow (Approaches Standards) | 12+ in Functional Requirements: Manual Testing && 11+ in Code Review, or the instructor judges that this project needs special attention | |
| Red (Not at Standard) | 0-10 in Code Review or 0-11 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging, or the instructor judges that this project needs special attention |
Code Style Bonus Awards
Was the code particularly impressive in code style for any of these reasons (or more...?)
| Quality | Yes? |
|---|---|
| Perfect Indentation | ✅ |
| Elegant/Clever | ✅ |
| Descriptive/Readable | ✅ |
| Concise | ✅ |
| Logical/Organized | ✅ |
Comment on lines
+5
to
+23
| <h4>Top Movies</h4> | ||
| <ul> | ||
| <% Work.top_ten('movie').each do |work|%> | ||
| <li><%= link_to work.title, work_path(work.id) %></li> | ||
| <% end %> | ||
| </ul> | ||
|
|
||
| <h4>Top Books</h4> | ||
| <ul><% Work.top_ten('book').each do |work|%> | ||
| <li><%= link_to work.title, work_path(work.id) %></li> | ||
| <% end %> | ||
| </ul> | ||
|
|
||
| <h4>Top Albums</h4> | ||
| <ul> | ||
| <% Work.top_ten('album').each do |work|%> | ||
| <li><%= link_to work.title, work_path(work.id) %></li> | ||
| <% end %> | ||
| </ul> |
There was a problem hiding this comment.
Not that these three bits of code are all very similar. Great work using a model method to grab the top ten from a particular category. A loop of a partial view could further DRY up this code.
|
|
||
| def logout | ||
| if session[:user_id] | ||
| user = User.find_by(id: session[:user_id]) |
There was a problem hiding this comment.
You have this code a few places. Consider moving this logic to a controller filter method in application controller so that you have access to the current_user throughout your program.
Comment on lines
+13
to
+14
| vote1 = Vote.create(work_id: work1.id, user_id: new_user.id) | ||
| vote2 = Vote.create(work_id: work2.id, user_id: new_user.id) |
There was a problem hiding this comment.
Good use of fixtures for works and users. You can also use fixtures for votes.
| validates :category, presence:true | ||
| validates :title, presence: true, uniqueness: true | ||
|
|
||
| def self.top_ten(category) |
There was a problem hiding this comment.
These methods are clean and concise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Media Ranker
Congratulations! You're submitting your assignment!
Comprehension Questions
sessionandflash? What is the difference between them?Assignment Submission: Media Ranker
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.
Reflection
sessionandflash? What is the difference between them?