fire | sandy #39
Open
fire | sandy #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 22 commits
November 10, 2020 09:39
kaidamasaki
reviewed
Nov 20, 2020
There was a problem hiding this comment.
Your submission was largely incomplete. Much of what is here looks good but just looks unfinished.
The main learning goal I'd like to see you hit going forward is on model testing.
Media Ranker
Functional Requirements: Manual Testing
| Criteria | yes/no |
|---|---|
| Before logging in | -- |
| 1. On index page, there are at most 10 pieces of media on three lists, and a Media Spotlight | Doesn't limit to 10 pieces of media. |
| 2. Can go into a work's show page | ✔️ |
| 3. Verify unable to vote on a work, and get a flash message | Broken view. |
| 4. Can edit this work successfully, and get a flash message | ✔️ |
| 5. Can go to "View all media" page and see three lists of works, sorted by vote | Not sorted by vote. |
| 6. Verify unable to create a new work when the form is empty, and details about the validation errors are visible to the user through a flash message | No details about error. |
| 7. Can create a new work successfully. Note the URL for this work's show page | ✔️ |
| 8. Can delete this work successfully | ✔️ |
| 9. Going back to the URL of this deleted work's show page produces a 404 or some redirect behavior (and does not try to produce a broken view) | ✔️ |
| 10. Verify that the "View all users" page lists no users | Hardcoded to a single user. |
| Log in | -- |
| 11. Logging in with a valid name changes the UI to "Logged in as" and "Logout" buttons | ✔️ |
| 12. Your username is listed in "View all users" page | Hardcoded to a single user. |
| 13. Verify that number of votes determines the Media Spotlight | |
| 14. Voting on several different pieces of media affects the "Votes" tables shown in the work's show page and the user's show page | |
| 15. Voting on the same work twice produces an error and flash message, and there is no extra vote | |
| Log out | -- |
| 16. Logging out showed a flash message and changed the UI | |
| 17. Logging in as a new user creates a new user | ✔️ |
| 18. Logging in as an already existing user has a specific flash message |
Major Learning Goals/Code Review
| Criteria | yes/no |
|---|---|
| 1. Sees the full development cycle including deployment, and the app is deployed to Heroku | ✔️ |
| 2. Practices full-stack development and fulfilling story requirements: the styling, look, and feel of the app is similar to the original Media Ranker | |
| 3. Practices git with at least 25 small commits and meaningful commit messages | Only 22 commits. |
Previous Rails learning, Building Complex Model Logic, DRYing up Rails Code
| Criteria | yes/no |
|---|---|
4. Routes file uses resources for works |
|
| 5. Routes file shows intention in limiting routes for voting, log-in functionality, and users | |
| 6. The homepage view, all media view, and new works view use semantic HTML | ✔️ |
| 7. The homepage view, all media view, and new works view use partials when appropriate | |
8. The model for media (likely named work.rb) has_many votes |
✔️ |
| 9. The model for media has methods to describe business logic, specifically for top ten and top media, possibly also for getting works by some category | No top ten method. |
10. Some controller, likely the ApplicationController, has a controller filter for finding a logged in user |
✔️ |
11. Some controller, likely the WorksController, has a controller filter for finding a work |
|
12. The WorksController uses strong params |
✔️ |
13. The WorksController's code style is clean, and focused on working with requests, responses, params, session, flash |
✔️ |
Testing Rails Apps
| Criteria | yes/no |
|---|---|
| 14. There are valid fixtures files used for users, votes, and works | No fixtures. |
| 15. User model has tests with sections on validations (valid and invalid) and relationships (has votes) | No relationship tests. |
| 16. Vote model has tests with sections on validations (valid and invalid) and relationships (belongs to a user, belongs to a vote) | ✔️ |
| 17. Work model has tests with sections on validations (valid and invalid) and relationships (has votes) | No relationship tests. |
| 18. Work model has tests with a section on all business logic methods in the model, including their edge cases | No business logic tests. |
Overall Feedback
| Overall Feedback | Criteria | yes/no |
|---|---|---|
| Green (Meets/Exceeds Standards) | 14+ in Functional Requirements: Manual Testing && 14+ in Code Review | |
| Yellow (Approaches Standards) | 12+ in Functional Requirements: Manual Testing && 11+ in Code Review, or the instructor judges that this project needs special attention | |
| Red (Not at Standard) | 0-10 in Code Review or 0-11 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging, or the instructor judges that this project needs special attention | ✔️ |
app/controllers/users_controller.rb
Outdated
| session[:user_id] = user.id #setting the session id to the user_id | ||
| flash[:success] = "Successfully logged in as returning user: #{user.name}" | ||
| else | ||
| #new user |
kaidamasaki
reviewed
Dec 4, 2020
There was a problem hiding this comment.
You made really good progress here. It's still red but it's so close to being yellow. If you'd gotten one more piece of functionality the assignment would have been yellow.
Media Ranker
Functional Requirements: Manual Testing
| Criteria | yes/no |
|---|---|
| Before logging in | -- |
| 1. On index page, there are at most 10 pieces of media on three lists, and a Media Spotlight | ✔️ |
| 2. Can go into a work's show page | ✔️ |
| 3. Verify unable to vote on a work, and get a flash message | ✔️ |
| 4. Can edit this work successfully, and get a flash message | ✔️ |
| 5. Can go to "View all media" page and see three lists of works, sorted by vote | Not sorted by vote. |
| 6. Verify unable to create a new work when the form is empty, and details about the validation errors are visible to the user through a flash message | ✔️ |
| 7. Can create a new work successfully. Note the URL for this work's show page | ✔️ |
| 8. Can delete this work successfully | ✔️ |
| 9. Going back to the URL of this deleted work's show page produces a 404 or some redirect behavior (and does not try to produce a broken view) | ✔️ |
| 10. Verify that the "View all users" page lists no users | Only lists hardcoded user. |
| Log in | -- |
| 11. Logging in with a valid name changes the UI to "Logged in as" and "Logout" buttons | ✔️ |
| 12. Your username is listed in "View all users" page | Only lists hardcoded user. |
| 13. Verify that number of votes determines the Media Spotlight | Media spotlight is random. |
| 14. Voting on several different pieces of media affects the "Votes" tables shown in the work's show page and the user's show page | Votes table is not updated. |
| 15. Voting on the same work twice produces an error and flash message, and there is no extra vote | Can vote on the same work twice. |
| Log out | -- |
| 16. Logging out showed a flash message and changed the UI | ✔️ |
| 17. Logging in as a new user creates a new user | ✔️ |
| 18. Logging in as an already existing user has a specific flash message | ✔️ |
Major Learning Goals/Code Review
| Criteria | yes/no |
|---|---|
| 1. Sees the full development cycle including deployment, and the app is deployed to Heroku | ✔️ |
| 2. Practices full-stack development and fulfilling story requirements: the styling, look, and feel of the app is similar to the original Media Ranker | ✔️ |
| 3. Practices git with at least 25 small commits and meaningful commit messages | ✔️ |
Previous Rails learning, Building Complex Model Logic, DRYing up Rails Code
| Criteria | yes/no |
|---|---|
4. Routes file uses resources for works |
✔️ |
| 5. Routes file shows intention in limiting routes for voting, log-in functionality, and users | ✔️ |
| 6. The homepage view, all media view, and new works view use semantic HTML | ✔️ |
| 7. The homepage view, all media view, and new works view use partials when appropriate | ✔️ |
8. The model for media (likely named work.rb) has_many votes |
✔️ |
| 9. The model for media has methods to describe business logic, specifically for top ten and top media, possibly also for getting works by some category | No top ten method. |
10. Some controller, likely the ApplicationController, has a controller filter for finding a logged in user |
✔️ |
11. Some controller, likely the WorksController, has a controller filter for finding a work |
No filter for finding a work. |
12. The WorksController uses strong params |
✔️ |
13. The WorksController's code style is clean, and focused on working with requests, responses, params, session, flash |
✔️ |
Testing Rails Apps
| Criteria | yes/no |
|---|---|
| 14. There are valid fixtures files used for users, votes, and works | No fixtures. |
| 15. User model has tests with sections on validations (valid and invalid) and relationships (has votes) | Tests exist but are failing. |
| 16. Vote model has tests with sections on validations (valid and invalid) and relationships (belongs to a user, belongs to a vote) | ✔️ |
| 17. Work model has tests with sections on validations (valid and invalid) and relationships (has votes) | ✔️ |
| 18. Work model has tests with a section on all business logic methods in the model, including their edge cases | No business logic tests. |
Overall Feedback
| Overall Feedback | Criteria | yes/no |
|---|---|---|
| Green (Meets/Exceeds Standards) | 14+ in Functional Requirements: Manual Testing && 14+ in Code Review | |
| Yellow (Approaches Standards) | 12+ in Functional Requirements: Manual Testing && 11+ in Code Review, or the instructor judges that this project needs special attention | ✔️ |
| Red (Not at Standard) | 0-10 in Code Review or 0-11 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging, or the instructor judges that this project needs special attention |
Comment on lines
+2
to
+3
| belongs_to :user | ||
| belongs_to :work |
There was a problem hiding this comment.
You probably wanted a validation here to prevent users from voting twice.
Comment on lines
4
to
6
| @movies = Work.all.select { |w| w.category == "movie" } | ||
| @books = Work.all.select { |w| w.category == "book" } | ||
| @albums = Work.all.select { |w| w.category == "album" } |
There was a problem hiding this comment.
Instead of returning all of the works here you should only return up to 10 of each category.
Comment on lines
+12
to
+16
| <tr> | ||
| <td><a href="/users/615">dee</a></td> | ||
| <td>0</td> | ||
| <td>May 13, 2020</td> | ||
| </tr> |
There was a problem hiding this comment.
You should have loaded the Users instead of hardcoding this here.
Comment on lines
+5
to
+8
| def self.spotlight | ||
| spotlight_for_all_works = Work.all.sample | ||
| return spotlight_for_all_works | ||
| end |
There was a problem hiding this comment.
Your spotlight should have only sampled from the works with the most votes.
| <section class="spotlight"> | ||
| <h2 class="spotlight__header"> | ||
| <span class="spotlight__header--prefix">Media Spotlight</span> | ||
| <a class="spotlight__link-to" href="works/605.html"><%[email protected]%></a> <br> |
There was a problem hiding this comment.
This should have linked to the work the was chosen to be spotlighted, instead of being hardcoded to work 605.
| @@ -0,0 +1,10 @@ | |||
| class Work < ApplicationRecord | |||
There was a problem hiding this comment.
You should have had a self.top_ten method here.
added 30 commits
December 2, 2021 23:15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Media Ranker
Congratulations! You're submitting your assignment!
Comprehension Questions
sessionandflash? What is the difference between them?