Earth - Beauttie #38

beauttie · 2020-11-16T10:35:56Z

Media Ranker

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe a custom model method you wrote.	I wrote a helper method that sorts all Work instances by vote count. Then I wrote a custom model method that gets all works in a category (passed in as a parameter) and calls that helper method to return the first 10 instances.
Describe how you approached testing that model method. What edge cases did you come up with?	I tested three cases: when there are more than 10 works, less than 10, and no works.
What are `session` and `flash`? What is the difference between them?	They both store data from a controller action. Data from flash hash is available until the next request cycle whereas data from session persists until the user quits the browser.
What was one thing that you gained more clarity on through this assignment?	Test fixtures
What is the Heroku URL of your deployed application?	https://work-of-art.herokuapp.com/

… create views for index and show

…tes, define indirect relations between users and works

…er action for Works

… user

CheezItMan

Media Ranker

Functional Requirements: Manual Testing

Criteria	yes/no
Before logging in	--
1. On index page, there are at most 10 pieces of media on three lists, and a Media Spotlight	✔️
2. Can go into a work's show page	✔️
3. Verify unable to vote on a work, and get a flash message	✔️
4. Can edit this work successfully, and get a flash message	✔️
5. Can go to "View all media" page and see three lists of works, sorted by vote	✔️
6. Verify unable to create a new work when the form is empty, and details about the validation errors are visible to the user through a flash message	✔️, but you're not using flash notices 😭
7. Can create a new work successfully. Note the URL for this work's show page	✔️
8. Can delete this work successfully	✔️
9. Going back to the URL of this deleted work's show page produces a 404 or some redirect behavior (and does not try to produce a broken view)	✔, but you should provide a flash message
10. Verify that the "View all users" page lists no users	✔️
Log in	--
11. Logging in with a valid name changes the UI to "Logged in as" and "Logout" buttons	✔️
12. Your username is listed in "View all users" page	✔️
13. Verify that number of votes determines the Media Spotlight	✔️
14. Voting on several different pieces of media affects the "Votes" tables shown in the work's show page and the user's show page	✔️
15. Voting on the same work twice produces an error and flash message, and there is no extra vote	✔️
Log out	--
16. Logging out showed a flash message and changed the UI	✔️
17. Logging in as a new user creates a new user	✔️
18. Logging in as an already existing user has a specific flash message	✔️

Major Learning Goals/Code Review

Criteria	yes/no
1. Sees the full development cycle including deployment, and the app is deployed to Heroku	✔️
2. Practices full-stack development and fulfilling story requirements: the styling, look, and feel of the app is similar to the original Media Ranker	✔️
3. Practices git with at least 25 small commits and meaningful commit messages	✔️

Previous Rails learning, Building Complex Model Logic, DRYing up Rails Code

Criteria	yes/no
4. Routes file uses `resources` for works	✔️
5. Routes file shows intention in limiting routes for voting, log-in functionality, and users	✔️
6. The homepage view, all media view, and new works view use semantic HTML	✔️
7. The homepage view, all media view, and new works view use partials when appropriate	⚠️ See my inline note on partials
8. The model for media (likely named `work.rb`) `has_many` votes	✔️
9. The model for media has methods to describe business logic, specifically for top ten and top media, possibly also for getting works by some category	✔️
10. Some controller, likely the `ApplicationController`, has a controller filter for finding a logged in user	⚠️, this filter isn't there
11. Some controller, likely the `WorksController`, has a controller filter for finding a work	✔️
12. The `WorksController` uses strong params	✔️
13. The `WorksController`'s code style is clean, and focused on working with requests, responses, `params`, `session`, `flash`	✔️

Testing Rails Apps

Criteria	yes/no
14. There are valid fixtures files used for users, votes, and works	✔️?
15. User model has tests with sections on validations (valid and invalid) and relationships (has votes)	✔️
16. Vote model has tests with sections on validations (valid and invalid) and relationships (belongs to a user, belongs to a vote)	✔️
17. Work model has tests with sections on validations (valid and invalid) and relationships (has votes)	✔️
18. Work model has tests with a section on all business logic methods in the model, including their edge cases	✔️

Overall Feedback

Overall Feedback	Criteria	yes/no
Green (Meets/Exceeds Standards)	14+ in Functional Requirements: Manual Testing && 14+ in Code Review	💚

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality	Yes?
Perfect Indentation	✅
Elegant/Clever	✅
Descriptive/Readable	✅
Concise	✅
Logical/Organized	✅

Summary

Nice work Beauttie! You hit the learning goals here. This is an outstanding submission. Well done.

The only area for improvement I can suggest is to make more use of partials, use flash notices to display error messages and use a controller filter to find the logged in user.

CheezItMan · 2020-11-23T03:14:18Z

config/routes.rb

+  # For details on the DSL available within this file, see https://guides.rubyonrails.org/routing.html
+  get "/login", to: "users#login_form", as: "login"
+  post "/login", to: "users#login"
+  post "/logout", to: "users#logout", as: "logout"
+  post "/works/:id/upvote", to: "works#upvote", as: "upvote"
+
+  root to: "works#homepage"
+
+  resources :works
+  resources :users, only: [:index, :show]


This works!

CheezItMan · 2020-11-23T03:14:59Z

app/models/work.rb

+  def self.sort_by_votes
+    # in descending order
+    return self.all.sort_by { |work| -work.votes.count }
+  end


This works, but it's better to use the database to sort with the order method. You can see a blog post on the subject to learn more.

CheezItMan · 2020-11-23T03:15:07Z

app/models/vote.rb

+  belongs_to :work
+  belongs_to :user
+
+  validates :work_id, uniqueness: { scope: :user_id, message: "User has already voted for this work" }


CheezItMan · 2020-11-23T03:16:04Z

app/views/works/index.html.erb

+        <% @works.where(category: category).sort_by_votes.each do |medium| %>
+          <tr>
+            <td><%= medium.votes.count %></td>
+            <td><%= link_to medium.title, work_path(medium) %></td>
+            <td><%= medium.creator %></td>
+            <td><%= medium.publication_year %></td>
+            <td><%= link_to "Upvote",
+                            upvote_path(medium),
+                            method: :post, class: "btn btn-primary"%></td>
+          </tr>
+        <% end %>


Do you notice that you repeat this type of loop through a set of works over and over again... Maybe you could put this into a partial and dry up your code.

CheezItMan · 2020-11-23T03:19:34Z

app/controllers/works_controller.rb

@@ -0,0 +1,91 @@
+class WorksController < ApplicationController
+  before_action :find_work, only: [:show, :edit, :update, :destroy]


👍 Yeah controller filter!

CheezItMan · 2020-11-23T03:23:19Z

app/views/users/login_form.html.erb

+  <section>
+    <% if @user.errors.any? %>
+      <div class="alert alert-warning">
+        <ul>
+          <% @user.errors.each do |column, message| %>
+            <li><strong><%= column %></strong> <%= message %></li>
+          <% end %>
+        </ul>
+      </div>
+    <% end %>
+  </section>


This should now be done with flash notices.

CheezItMan · 2020-11-23T03:28:48Z

test/models/user_test.rb

@@ -0,0 +1,55 @@
+require "test_helper"
+
+describe User do


CheezItMan · 2020-11-23T03:30:07Z

test/models/work_test.rb

+        expect(sorted_media.last.votes.count).must_equal 0
+      end
+
+      it "returns an empty array if there are no works" do


CheezItMan · 2020-11-23T03:30:25Z

test/models/work_test.rb

+      end
+    end
+
+    describe "top_10" do


👍 Well done

CheezItMan · 2020-11-23T03:31:04Z

test/models/work_test.rb

+      end
+    end
+
+    describe "spotlight" do


Good set of tests covering the edge cases.

beauttie added 30 commits November 10, 2020 03:33

Initial Rails setup

a3b0d92

Seed data, create controllers for Works and Users, define CR actions,…

c859251

… create views for index and show

Add views with partials, write controller tests

7733040

Add login and logout controller actions for User, create model for vo…

03198eb

…tes, define indirect relations between users and works

Establish indirect relations, test User model, create upvote controll…

5e27697

…er action for Works

Write test for Votes model

98930c2

Flash error message when user votes for the same work more than once

edc7bfb

Create custom methods for top ten media and spotlight

d48837d

Create view to show user's details

6b3aac2

DRY up index page for Works

d1f7252

Add table about votes for a work

b380f81

Configure root path to homepage view and created view for the homepage

5e73e84

Add header to all views, create link that indicates current logged in…

d4e9f40

… user

Add validations when logging in

9e7ed76

Tests for Work model before using fixtures

7c9ccc4

Write tests for custom methods in Work model

c884075

Fix test expectation counts that include fixture data

dbbc975

Write tests for upvote action in Works controller

8be2cd9

DRY up Works Controller with controller filters

e27fe02

Test for flash messages and redirects in Users controller

6611d7d

Change production settings for database

f4354e8

Change production settings for database again

b2e2d8c

Revert prod db changes

2b24d3f

Add flash to Works controller actions

757463a

Test flash for Works controller

da076c0

Fix Heroku deployment issue with spotlight

f318cf4

Add CSS to header, nav, spotlight

32e9bfd

Add CSS for spotlight and top ten lists

bc353c4

Add CSS for index page

005f989

Add CSS for new and edit actions

2539d9f

beauttie added 6 commits November 17, 2020 02:00

Add CSS for show action and login page

06810b1

Add CSS for Users show page

8bb72ba

Add CSS for flash messages

275bb2a

Edit name of flash keys to use CSS Bootstrap

cc7937a

Fix flash keys in Works controller tests

f051d8e

Finally figured out how to get rid of annoying border for top ten lists

5f5eddd

CheezItMan reviewed Nov 23, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Earth - Beauttie #38

Earth - Beauttie #38

beauttie commented Nov 16, 2020 •

edited

Loading

CheezItMan left a comment

CheezItMan Nov 23, 2020

CheezItMan Nov 23, 2020

CheezItMan Nov 23, 2020

CheezItMan Nov 23, 2020

CheezItMan Nov 23, 2020

CheezItMan Nov 23, 2020

CheezItMan Nov 23, 2020

CheezItMan Nov 23, 2020

CheezItMan Nov 23, 2020

CheezItMan Nov 23, 2020

		@@ -0,0 +1,91 @@
		class WorksController < ApplicationController
		before_action :find_work, only: [:show, :edit, :update, :destroy]

Earth - Beauttie #38

Are you sure you want to change the base?

Earth - Beauttie #38

Conversation

beauttie commented Nov 16, 2020 • edited Loading

Media Ranker

Comprehension Questions

CheezItMan left a comment

Choose a reason for hiding this comment

Media Ranker

Functional Requirements: Manual Testing

Major Learning Goals/Code Review

Previous Rails learning, Building Complex Model Logic, DRYing up Rails Code

Testing Rails Apps

Overall Feedback

Code Style Bonus Awards

Summary

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

beauttie commented Nov 16, 2020 •

edited

Loading