Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mona #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Mona #16

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 19 additions & 4 deletions lib/heap_sort.rb
Original file line number Diff line number Diff line change
@@ -1,8 +1,23 @@


# This method uses a heap to sort an array.
# Time Complexity: ?
# Space Complexity: ?
def heap_sort(list)
raise NotImplementedError, "Method not implemented yet..."
# Time Complexity: O(n log n)
# Space Complexity: O(n)
def heapsort(list)
Comment on lines +4 to +6

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


# swap first with the last
return list if list.empty?
heap = MinHeap.new # create a min heap

list.each do |element|
heap.add(element)
end

sorted = []
i = 0
while i < list.length
sorted << heap.remove
i += 1
end
sorted
end
58 changes: 45 additions & 13 deletions lib/min_heap.rb
Original file line number Diff line number Diff line change
Expand Up @@ -14,18 +14,25 @@ def initialize
end

# This method adds a HeapNode instance to the heap
# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(log n)
# Space Complexity: O(log n) - n is the number of elemnts in the heap
def add(key, value = key)
Comment on lines +17 to 19

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

raise NotImplementedError, "Method not implemented yet..."
# put the element to the back of the arr
@store << HeapNode.new(key, value)

heap_up(@store.length - 1)
end

# This method removes and returns an element from the heap
# maintaining the heap structure
# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(log n)
# Space Complexity: O(log n)
def remove()
Comment on lines +28 to 30

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

raise NotImplementedError, "Method not implemented yet..."
return nil if @store.empty?
swap(0, @store.length - 1) # swap the root & last node
removed = @store.pop
heap_down(0) # heap-down
return removed.value
end


Expand All @@ -44,28 +51,53 @@ def to_s
end

# This method returns true if the heap is empty
# Time complexity: ?
# Space complexity: ?
# Time complexity: O(1)
# Space complexity: O(1)
def empty?
Comment on lines +54 to 56

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

raise NotImplementedError, "Method not implemented yet..."
return @store.length == 0 ? true : false
end

private

# This helper method takes an index and
# moves it up the heap, if it is less than it's parent node.
# It could be **very** helpful for the add method.
# Time complexity: ?
# Space complexity: ?
# Time complexity: O(log n)
# Space complexity: O(log n)
def heap_up(index)
Comment on lines +65 to 67

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


# compare the new node with its parent, if they are out of order swap and heap-up
# to find the parents: i - 1 /2
return if index == 0 # base case
parent = (index - 1) / 2 # find the parent

if @store[index].key < @store[parent].key
swap(index, parent)
heap_up(parent)
end
end

# This helper method takes an index and
# moves it up the heap if it's smaller
# than it's parent node.
def heap_down(index)
Comment on lines 79 to 82

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

raise NotImplementedError, "Method not implemented yet..."
# compare root with its children
# make a swap with its largest child
min_child = index #0
left_child = 2 * index + 1 # 1
right_child = 2 * index + 2 # 3

if left_child < @store.length && @store[left_child].key < @store[min_child].key
swap(min_child, left_child)
end

if right_child < @store.length && @store[right_child].key < @store[min_child].key
swap(min_child, right_child)
end
Comment on lines +89 to +95

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, but you could end up doing more swaps than needed.


if min_child != index
swap(index, min_child)
heap_down(min_child)
end
end

# If you want a swap method... you're welcome
Expand Down
2 changes: 1 addition & 1 deletion test/heapsort_test.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
require_relative "test_helper"

xdescribe "heapsort" do
describe "heapsort" do
it "sorts an empty array" do
# Arrange
list = []
Expand Down