Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Water - Li #12

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions lib/heap_sort.rb
Original file line number Diff line number Diff line change
@@ -1,8 +1,18 @@


# This method uses a heap to sort an array.
# Time Complexity: ?
# Space Complexity: ?
def heap_sort(list)
raise NotImplementedError, "Method not implemented yet..."
# Time Complexity: O(nlogn): add O(nlogn) + remove O(nlogn)
# Space Complexity: O(n) for creating @store to store all the nodes
def heapsort(list)
Comment on lines +4 to +6

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

min_heap = MinHeap.new

list.each do |element|
min_heap.add(element)
end

list.map! do |element|
min_heap.remove
end

return list
end
59 changes: 46 additions & 13 deletions lib/min_heap.rb
Original file line number Diff line number Diff line change
Expand Up @@ -14,18 +14,25 @@ def initialize
end

# This method adds a HeapNode instance to the heap
# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(log n): push O(1) + heap_up O(log n)
# Space Complexity: O(log n) : heap_up O(log n)
def add(key, value = key)
Comment on lines +17 to 19

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

raise NotImplementedError, "Method not implemented yet..."
@store << HeapNode.new(key, value)
heap_up(@store.length - 1)
end

# This method removes and returns an element from the heap
# maintaining the heap structure
# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(log n): pop, swap O(1) + heap_down O(log n)
# Space Complexity: O(log n) from heap_down call stacks
def remove()
Comment on lines +26 to 28

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

raise NotImplementedError, "Method not implemented yet..."
return nil if @store.empty?

swap(0, @store.length - 1)
removed_element = @store.pop
heap_down(0) unless @store.empty?

return removed_element.value
end


Expand All @@ -44,28 +51,54 @@ def to_s
end

# This method returns true if the heap is empty
# Time complexity: ?
# Space complexity: ?
# Time complexity: O(1)
# Space complexity: O(1)
def empty?
Comment on lines +54 to 56

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

raise NotImplementedError, "Method not implemented yet..."
return @store.length == 0
end

private

# This helper method takes an index and
# moves it up the heap, if it is less than it's parent node.
# It could be **very** helpful for the add method.
# Time complexity: ?
# Space complexity: ?
# Time complexity: O(log n): swap - O(1), and we will do it up to O(log n) times
# Space complexity: O(log n) for call stacks
# min heap, the smallest node goes up to root
def heap_up(index)
Comment on lines +65 to 68

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


parent_index = (index - 1) / 2
#base cases - stop when in order(parent < child) or reach root
return @store if @store[index].key > @store[parent_index].key || index == 0

swap(index, parent_index)
heap_up(parent_index)

end

# This helper method takes an index and
# moves it up the heap if it's smaller
# than it's parent node.
# swap parent with the smaller child
# Time complexity: O(log n): find_smaller_childs_index - O(1), swap - O(1), and we will do it up to O(log n) times
# Space complexity: O(log n) for call stacks
def heap_down(index)
Comment on lines +81 to 84

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , I like the helper method!

raise NotImplementedError, "Method not implemented yet..."
left_child = index * 2 + 1
right_child = index * 2 + 2
smaller_child = find_smaller_childs_index(left_child, right_child)
#base cases - node has no child or in order(parent < child)
return @store if @store[smaller_child].nil? || @store[index].key < @store[smaller_child].key

swap(index, smaller_child)
heap_down(smaller_child)

end

def find_smaller_childs_index(left_index, right_index)
if @store[right_index]
return @store[left_index].key > @store[right_index].key ? right_index : left_index
else
return left_index
end
end

# If you want a swap method... you're welcome
Expand Down
2 changes: 1 addition & 1 deletion test/heapsort_test.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
require_relative "test_helper"

xdescribe "heapsort" do
describe "heapsort" do
it "sorts an empty array" do
# Arrange
list = []
Expand Down