Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

water - marj #38

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

Schmarj3
Copy link

@Schmarj3 Schmarj3 commented Jan 8, 2021

Assignment Submission: Exquisite React

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.

Question for instructors

-I disregarded the propTypes (and test because I saw something about this on slack) for this assignment, and I hope that is okay. I think I still learned what I was meant to, but if not, I will redo the assignment. I kind of approached this like media ranker with trying to match the original as close as possible, and it made it a much more interesting for me to be honest.

-wave-0.1 was the optional refactor, and I feel like I came close, but could not figure out a good was to include value={form fields.___}. If you have time, I would love to get feedback on this :)

Thank you for all you do~!

Reflection

Prompt Response
Define in your own words: What does "state" in React mean? How do we use it? state is a way to keep track of changes to a specific thing.
Describe the relationships between the components on a high-level: which components were siblings? Which components were nested within each other? all the components inside of Game were siblings, and Game the parent
How did this project differ from in-class examples? We only needed to add items to an overall list in the Game component, also there was a Game component that handled its baby components instead of having everything done in App
How was this project similar to in-class examples? We still needed to bubble up changes to state from the child to parent components

Copy link

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Marj, you have a fully functional Exquisite corpse game and you got all the tests to pass. Well done.

You didn't have to use our suggested prop-types or use the tests, but if you used different props, you should have adjusted the prop types. Prop types help document your components and explain to other devs how to use your components.

The tests are good guidelines to help make sure your components perform as expected. They're also not too hard to get working as they interact with the components like a use would, for the most part.


// creat list of all submissions
const finalPoem = props.submissions.map(sentence => {
return <p>{sentence}</p>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to include keys here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants