Water - Beatrice #31
Open
Water - Beatrice #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Jan 16, 2021
There was a problem hiding this comment.
Nice work Beatrice, you have a fully functional Exquisite corpse game and you got all the tests to pass. Well done.
You are failing a few tests, the reasons of which is just because you're hiding content with CSS and the tests are still seeing the HTML elements in the resulting page.
| @@ -25,12 +64,15 @@ const Game = () => { | |||
| { exampleFormat } | |||
| </p> | |||
|
|
|||
| <RecentSubmission /> | |||
| <div className={showRecentSubmission() ? 'visible' : 'hidden'}> | |||
| <RecentSubmission submission={poem[poem.length-1]}/> | |||
There was a problem hiding this comment.
Just note that if poem is empty this will send undefined to the prop submission and that's why you're getting a warning.
| <div className="FinalPoem"> | ||
| <section className="FinalPoem__poem"> | ||
| <div className='FinalPoem'> | ||
| <section className={`FinalPoem__poem ${props.isSubmitted ? 'visible' : 'hidden'}`}> |
There was a problem hiding this comment.
You're hiding the content based on CSS while the test just assumes it's not rendered at all, which is why the test fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assignment Submission: Exquisite React
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.
Reflection